Page MenuHomePhabricator

[MLIR] change to the most useful variant.

Authored by timshen on Feb 14 2020, 3:26 PM.



the .row.col variant turns out to be the popular one, contrary to what I
thought as .row.row. Since .row.col is so prevailing (as I inspect
cuDNN's behavior), I'm going to remove the .row.row support here, which
makes the patch a little bit easier.

Diff Detail

Event Timeline

timshen created this revision.Feb 14 2020, 3:26 PM
ftynse accepted this revision.Feb 17 2020, 1:00 AM

In the longer term, we should just expose all variants, possibly with a default, and make sure all of them are lowered correctly.

This revision is now accepted and ready to land.Feb 17 2020, 1:00 AM
This revision was automatically updated to reflect the committed changes.