This is an archive of the discontinued LLVM Phabricator instance.

Differential D74578

[GWP-ASan] Silence gcc error
ClosedPublic

Authored by cryptoad on Feb 13 2020, 12:56 PM.

Details

Reviewers
eugenis
hctim
morehouse
Commits
rGef7488ef205c: [GWP-ASan] Silence gcc error
Summary

It complains about reaching the end of a non-void returning function.

Diff Detail

Event Timeline

cryptoad created this revision.Feb 13 2020, 12:56 PM
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptFeb 13 2020, 12:56 PM
Herald added a subscriber: Restricted Project. · View Herald Transcript
hctim accepted this revision.Feb 13 2020, 1:06 PM

LGTM. Thanks.

This revision is now accepted and ready to land.Feb 13 2020, 1:06 PM
Closed by commit rGef7488ef205c: [GWP-ASan] Silence gcc error (authored by cryptoad). · Explain WhyFeb 13 2020, 1:11 PM
This revision was automatically updated to reflect the committed changes.
Harbormaster failed remote builds in B46442: Diff 244514!Feb 13 2020, 1:20 PM

Revision Contents

PathSize
compiler-rt/
lib/
gwp_asan/
platform_specific/
1 line

Diff 244520

compiler-rt/lib/gwp_asan/platform_specific/utilities_posix.cpp

Show First 20 Lines • Show All 78 Lines • ▼ Show 20 Lines case AlignmentStrategy::BIONIC:
return alignBionic(RealAllocationSize); return alignBionic(RealAllocationSize);
case AlignmentStrategy::POWER_OF_TWO: case AlignmentStrategy::POWER_OF_TWO:
return alignPowerOfTwo(RealAllocationSize); return alignPowerOfTwo(RealAllocationSize);
case AlignmentStrategy::PERFECT: case AlignmentStrategy::PERFECT:
return RealAllocationSize; return RealAllocationSize;
case AlignmentStrategy::DEFAULT: case AlignmentStrategy::DEFAULT:
__builtin_unreachable(); __builtin_unreachable();
} }
__builtin_unreachable();
} }
} // namespace gwp_asan } // namespace gwp_asan