Page MenuHomePhabricator

Reenable "Always import constants" after compile time fixes
ClosedPublic

Authored by tejohnson on Feb 12 2020, 3:27 PM.

Details

Summary

Reenables importing of constants by default, which was disabled in
D73724 due to excessive thin link times. These inefficiencies were
fixed in D73851.

I re-measured thin link times for a number of binaries that had compile
time explosions with importing of constants previously and confirmed
they no longer have any notable increases with it enabled.

Diff Detail

Event Timeline

tejohnson created this revision.Feb 12 2020, 3:27 PM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 12 2020, 3:27 PM
This revision is now accepted and ready to land.Feb 14 2020, 5:04 AM
This revision was automatically updated to reflect the committed changes.