Page MenuHomePhabricator

[ARCMT][NFC] Reduce #include dependencies
ClosedPublic

Authored by nicolas17 on Feb 10 2020, 10:40 PM.

Details

Summary

Replace some #includes in ARCMigrate source files with more specific includes and forward declarations. This reduces the number of files that need to be rebuilt when a header changes (and saves like 1 second of build time). For example, several files no longer need to be rebuilt when the list of static analyzer checkers(!) changes.

Diff Detail

Event Timeline

nicolas17 created this revision.Feb 10 2020, 10:40 PM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 10 2020, 10:40 PM
Herald added a subscriber: cfe-commits. · View Herald Transcript

LGTM, as long as it builds fine.

akyrtzi accepted this revision.Feb 11 2020, 8:29 AM
This revision is now accepted and ready to land.Feb 11 2020, 8:29 AM

I don't have commit access, can someone push this for me?

I don't have commit access, can someone push this for me?

Sure, can you just confirm that you're this guy: https://github.com/nicolas17 (I need that for proper email attribution)

Sure, can you just confirm that you're this guy: https://github.com/nicolas17 (I need that for proper email attribution)

Yes that's me :)

This revision was automatically updated to reflect the committed changes.