Page MenuHomePhabricator

[llvm-exegesis] Improve error reporting in Assembler.cpp
ClosedPublic

Authored by mstojanovic on Feb 10 2020, 7:41 AM.

Details

Summary

Followup to D74085.
Replace the use of report_fatal_error() with returning the error to llvm-exegesis.cpp and handling it there.

Diff Detail

Event Timeline

mstojanovic created this revision.Feb 10 2020, 7:41 AM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 10 2020, 7:41 AM
Herald added a subscriber: tschuett. · View Herald Transcript
mstojanovic marked an inline comment as done.Feb 10 2020, 7:45 AM
mstojanovic added inline comments.
llvm/tools/llvm-exegesis/lib/Assembler.cpp
307

This is the only use of this function left in the tool but I ended up leaving it in because removing it would require adding a lot of boilerplate code due to its placement inside of a constructor.

This revision is now accepted and ready to land.Feb 18 2020, 5:20 AM
This revision was automatically updated to reflect the committed changes.