Change default relocation model for hexagon when triple includes musl

[sidneym]

Summary

Right now if the triple includes musl, saying something like: "--target=x86_64--linux-musl" then the default relocation model is pic. When the target is hexagon I want the default relocation model to be static.

[bcain]

clang/lib/Driver/ToolChains/Linux.cpp

923

But if

getSanitizerArgs().requiresPIE() && getTriple().getArch() == llvm::Triple::hexagon

.... then the != hexagon takes precedence? Seems like "sanitizer requires PIE" should, right?

clang/lib/Driver/ToolChains/Linux.cpp

if (GCCInstallation.isValid()) {
     CC1Args.push_back("-isystem");
     CC1Args.push_back(DriverArgs.MakeArgString(
         GCCInstallation.getParentLibPath() + "/../" +
         GCCInstallation.getTriple().str() + "/include"));
   }
 }
 
 bool Linux::isPIEDefault() const {
-  return (getTriple().isAndroid() && !getTriple().isAndroidVersionLT(16)) ||
-          getTriple().isMusl() || getSanitizerArgs().requiresPIE();
+  return ((getTriple().isAndroid() && !getTriple().isAndroidVersionLT(16)) ||
+          getTriple().isMusl() || getSanitizerArgs().requiresPIE()) &&
+          getTriple().getArch() != llvm::Triple::hexagon;
 }
 
 bool Linux::isNoExecStackDefault() const {
     return getTriple().isAndroid();
 }
 
 bool Linux::IsMathErrnoDefault() const {
   if (getTriple().isAndroid())

clang/test/Driver/hexagon-toolchain-elf.c

 // RUN: %clang -### -target hexagon-unknown-elf \
 // RUN:   -ccc-install-dir %S/Inputs/hexagon_tree/Tools/bin \
 // RUN:   -mcpu=hexagonv60 \
 // RUN:   -fuse-ld=lld \
 // RUN:   %s 2>&1 \
 // RUN:   | FileCheck -check-prefix=CHECK082 %s
 // CHECK082-NOT:      -march=
 // CHECK082-NOT:      -mcpu=
+// -----------------------------------------------------------------------------
+// Check default relocation model
+// -----------------------------------------------------------------------------
+// RUN: %clang -### -target hexagon-linux-unknown-musl \
+// RUN:   -ccc-install-dir %S/Inputs/hexagon_tree/Tools/bin \
+// RUN:   -mcpu=hexagonv60 \
+// RUN:   %s 2>&1 \
+// RUN:   | FileCheck -check-prefix=CHECK083 %s
+// CHECK083: "-mrelocation-model" "static"
+// -----------------------------------------------------------------------------
+// Check default relocation model when -fpic is passed
+// -----------------------------------------------------------------------------
+// RUN: %clang -### -target hexagon-linux-unknown-musl -fpic \
+// RUN:   -ccc-install-dir %S/Inputs/hexagon_tree/Tools/bin \
+// RUN:   -mcpu=hexagonv60 \
+// RUN:   %s 2>&1 \
+// RUN:   | FileCheck -check-prefix=CHECK084 %s
+// CHECK084: "-mrelocation-model" "pic"