This is an archive of the discontinued LLVM Phabricator instance.

Paths

Table of Contentst

-
llvm/tools/llvm-dwarfdump/
-
tools/
-
llvm-dwarfdump/
1
Statistics.cpp

Differential D74207

[llvm-dwarfdump][Stats] Add the License header
ClosedPublic

Authored by djtodoro on Feb 7 2020, 3:12 AM.

Download Raw Diff

Details

Reviewers

aprantl
vsk
jhenderson

Commits

rGd180899cb710: [llvm-dwarfdump][Stats] Fix the License header
rGd173cb1db73a: [llvm-dwarfdump][Stats] Add the license header

Summary

Add the License header into the Statistics.cpp

Diff Detail

Repository: rG LLVM Github Monorepo

Event Timeline

djtodoro created this revision.Feb 7 2020, 3:12 AM

Herald added a reviewer: jhenderson. · View Herald TranscriptFeb 7 2020, 3:12 AM

Herald added a project: Restricted Project. · View Herald Transcript

Herald added a subscriber: llvm-commits. · View Herald Transcript

djtodoro added a parent revision: D74206: [llvm-dwarfdump][SecSize] Add the percentage of the whole binary.Feb 7 2020, 3:16 AM

djtodoro added a child revision: D74208: [llvm-dwarfdump] Add the docs and test for the show-sections-sizes option.

LGTM.

This revision is now accepted and ready to land.Feb 7 2020, 3:17 AM

By the way, this is completely independent of anything else in the patch series, so please commit it as soon as you can.

Yes, I do not know why I put in the stack. I will land this. Thanks!

Closed by commit rGd173cb1db73a: [llvm-dwarfdump][Stats] Add the license header (authored by djtodoro). · Explain WhyFeb 7 2020, 3:41 AM

This revision was automatically updated to reflect the committed changes.

aprantl added inline comments.Feb 7 2020, 8:49 AM

llvm/tools/llvm-dwarfdump/Statistics.cpp
2	This is doubly broken :-) The language mark is spelled `-- C++ --` It only makes sense to put this into a .h file where the programming language is ambiguous. A .cpp file is always C++.

djtodoro removed a parent revision: D74206: [llvm-dwarfdump][SecSize] Add the percentage of the whole binary.Feb 7 2020, 8:54 AM

djtodoro removed a child revision: D74208: [llvm-dwarfdump] Add the docs and test for the show-sections-sizes option.

Oh, I'm sorry, I didn't know :(

@aprantl Is it better?

djtodoro reopened this revision.Feb 7 2020, 9:05 AM

This revision is now accepted and ready to land.Feb 7 2020, 9:05 AM

Yes, thanks!

Closed by commit rGd180899cb710: [llvm-dwarfdump][Stats] Fix the License header (authored by djtodoro). · Explain WhyFeb 9 2020, 11:11 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents

Path

Size

llvm/

tools/

llvm-dwarfdump/

2 lines

Diff 243474

llvm/tools/llvm-dwarfdump/Statistics.cpp

	//===- Statistics.cpp ------------------------------------------- - C++ -===//			//===-- Statistics.cpp - Debug Info quality metrics -----------------------===//
	//			//
				aprantlUnsubmitted Not Done Reply Inline Actions This is doubly broken :-) The language mark is spelled `-- C++ --` It only makes sense to put this into a .h file where the programming language is ambiguous. A .cpp file is always C++. aprantl: This is doubly broken :-) 1. The language mark is spelled `-- C++ --` 2. It only makes sense…
	// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.			// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
	// See https://llvm.org/LICENSE.txt for license information.			// See https://llvm.org/LICENSE.txt for license information.
	// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception			// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
	//			//
	//===----------------------------------------------------------------------===//			//===----------------------------------------------------------------------===//

	#include "llvm/ADT/DenseMap.h"			#include "llvm/ADT/DenseMap.h"
	#include "llvm/ADT/StringExtras.h"			#include "llvm/ADT/StringExtras.h"
	▲ Show 20 Lines • Show All 617 Lines • Show Last 20 Lines