This is an archive of the discontinued LLVM Phabricator instance.

Differential D74126

[lldb] Remove all 'clean' targets from test Makefiles
ClosedPublic

Authored by teemperor on Feb 6 2020, 6:10 AM.

Details

Reviewers
labath
JDevlieghere
Commits
rG68cc9f80a6bf: [lldb] Remove all 'clean' targets from test Makefiles
Summary

To my knowledge we don't actually use or need these rules. And if we need them then
there is probably a better way to implement this than having all these random regexes.

Diff Detail

Event Timeline

teemperor created this revision.Feb 6 2020, 6:10 AM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 6 2020, 6:10 AM
Herald added a subscriber: lldb-commits. · View Herald Transcript
teemperor updated this revision to Diff 242899.Feb 6 2020, 7:12 AM
  • Reverted some removal for bundle tests that somehow use this.
labath accepted this revision.Feb 6 2020, 8:30 AM

Yes, I don't think we need to maintain this. Now that the tests our built out of tree, we can clean them by just nuking the build folder.

This revision is now accepted and ready to land.Feb 6 2020, 8:30 AM
JDevlieghere accepted this revision.Feb 6 2020, 9:33 AM
jingham added a subscriber: jingham.EditedFeb 6 2020, 11:15 AM

The one use I had for these clean targets was when you are making a new test and getting the test source to compile it is really tempting to run make in the test directory. It's a lot slower to go run the test, see the compile fail, fix something, etc... than just run make. But if you do that and don't clean, then when you actually go to run the test, it will fail because make sees the product in the source directory and won't build it in the out-of-line directory, but the test will look for it there.

Not a super compelling reason, but...

teemperor updated this revision to Diff 243106.Feb 7 2020, 2:24 AM
  • Rebased
Closed by commit rG68cc9f80a6bf: [lldb] Remove all 'clean' targets from test Makefiles (authored by teemperor). · Explain WhyFeb 7 2020, 2:28 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
lldb/
packages/
Python/
lldbsuite/
test/
api/
multithreaded/
3 lines
commands/
expression/
call-function/
3 lines
functionalities/
breakpoint/
comp_dir_symlink/
3 lines
data-formatter/
synthupdate/
3 lines
memory-region/
3 lines
tail_call_frames/
cross_dso/
4 lines
target_var/
3 lines
lang/
c/
conflicting-symbol/
4 lines
cpp/
char1632_t/
2 lines
enum_types/
4 lines
overriden-methods/
3 lines
stl/
2 lines
unicode-literals/
2 lines
wchar_t/
2 lines
objc/
objc-ivar-stripped/
4 lines
objc-static-method-stripped/
4 lines
linux/
add-symbols/
3 lines
mix-dwo-and-regular-objects/
4 lines
sepdebugsymlink/
3 lines
macosx/
find-app-in-bundle/
3 lines
universal/
3 lines
python_api/
findvalue_duplist/
4 lines
formatters/
4 lines
sbvalue_persist/
3 lines
source-manager/
4 lines

Diff 243106

lldb/packages/Python/lldbsuite/test/api/multithreaded/Makefile

ENABLE_THREADS := YES ENABLE_THREADS := YES
CXX_SOURCES := main.cpp CXX_SOURCES := main.cpp
include Makefile.rules include Makefile.rules
clean::
rm -rf $(wildcard *.o *.d *.dSYM)

lldb/packages/Python/lldbsuite/test/commands/expression/call-function/Makefile

CXX_SOURCES := main.cpp CXX_SOURCES := main.cpp
include Makefile.rules include Makefile.rules
clean::
rm -rf $(wildcard *.o *.d *.dSYM)

lldb/packages/Python/lldbsuite/test/functionalities/breakpoint/comp_dir_symlink/Makefile

CXX_SOURCES := relative.cpp CXX_SOURCES := relative.cpp
EXE := CompDirSymLink EXE := CompDirSymLink
include Makefile.rules include Makefile.rules
# Force relative filenames by copying it into the build directory. # Force relative filenames by copying it into the build directory.
relative.cpp: main.cpp relative.cpp: main.cpp
cp -f $< $@ cp -f $< $@
clean::
rm -rf relative.cpp

lldb/packages/Python/lldbsuite/test/functionalities/data-formatter/synthupdate/Makefile

OBJC_SOURCES := main.m OBJC_SOURCES := main.m
CFLAGS_EXTRAS := -w CFLAGS_EXTRAS := -w
LD_EXTRAS := -framework Foundation LD_EXTRAS := -framework Foundation
include Makefile.rules include Makefile.rules
clean::
rm -rf $(wildcard *.o *.d *.dSYM *.log)

lldb/packages/Python/lldbsuite/test/functionalities/memory-region/Makefile

CXX_SOURCES := main.cpp CXX_SOURCES := main.cpp
include Makefile.rules include Makefile.rules
clean::
rm -rf $(wildcard *.o *.d *.dSYM)

lldb/packages/Python/lldbsuite/test/functionalities/tail_call_frames/cross_dso/Makefile

LD_EXTRAS := -L. -l$(LIB_PREFIX)One -l$(LIB_PREFIX)Two LD_EXTRAS := -L. -l$(LIB_PREFIX)One -l$(LIB_PREFIX)Two
C_SOURCES := main.c C_SOURCES := main.c
CFLAGS_EXTRAS := -g -O2 -glldb CFLAGS_EXTRAS := -g -O2 -glldb
include Makefile.rules include Makefile.rules
.PHONY: .PHONY:
a.out: lib_One lib_Two a.out: lib_One lib_Two
lib_One: lib_Two lib_One: lib_Two
lib_%: lib_%:
$(MAKE) VPATH=$(SRCDIR)/$* -I $(SRCDIR) -f $(SRCDIR)/$*.mk DSYMUTIL=$(DSYMUTIL) $(MAKE) VPATH=$(SRCDIR)/$* -I $(SRCDIR) -f $(SRCDIR)/$*.mk DSYMUTIL=$(DSYMUTIL)
clean::
$(MAKE) -f $(SRCDIR)/One.mk clean
$(MAKE) -f $(SRCDIR)/Two.mk clean

lldb/packages/Python/lldbsuite/test/functionalities/target_var/Makefile

include Makefile.rules include Makefile.rules
a.out: globals.ll a.out: globals.ll
$(CC) $(CFLAGS) -g -c $^ -o globals.o $(CC) $(CFLAGS) -g -c $^ -o globals.o
$(LD) $(LDFLAGS) -g globals.o -o $@ $(LD) $(LDFLAGS) -g globals.o -o $@
clean::
rm -rf globals.o a.out *.dSYM

lldb/packages/Python/lldbsuite/test/lang/c/conflicting-symbol/Makefile

LD_EXTRAS := -L. -LOne -l$(LIB_PREFIX)One -LTwo -l$(LIB_PREFIX)Two LD_EXTRAS := -L. -LOne -l$(LIB_PREFIX)One -LTwo -l$(LIB_PREFIX)Two
C_SOURCES := main.c C_SOURCES := main.c
include Makefile.rules include Makefile.rules
.PHONY: .PHONY:
a.out: lib_One lib_Two a.out: lib_One lib_Two
lib_%: lib_%:
$(MAKE) VPATH=$(SRCDIR)/$* -I $(SRCDIR) -f $(SRCDIR)/$*.mk $(MAKE) VPATH=$(SRCDIR)/$* -I $(SRCDIR) -f $(SRCDIR)/$*.mk
clean::
$(MAKE) -f $(SRCDIR)/One.mk clean
$(MAKE) -f $(SRCDIR)/Two.mk clean

lldb/packages/Python/lldbsuite/test/lang/cpp/char1632_t/Makefile

CXX_SOURCES := main.cpp CXX_SOURCES := main.cpp
CFLAGS :=-g -O0 -std=c++11 CFLAGS :=-g -O0 -std=c++11
clean: OBJECTS+=$(wildcard main.d.*)
include Makefile.rules include Makefile.rules

lldb/packages/Python/lldbsuite/test/lang/cpp/enum_types/Makefile

CXX_SOURCES := main.cpp CXX_SOURCES := main.cpp
CXXFLAGS_EXTRAS := -std=c++11 CXXFLAGS_EXTRAS := -std=c++11
clean: OBJECTS+=$(wildcard main.d.*)
include Makefile.rules include Makefile.rules

lldb/packages/Python/lldbsuite/test/lang/cpp/overriden-methods/Makefile

CXX_SOURCES := main.cpp CXX_SOURCES := main.cpp
include Makefile.rules include Makefile.rules
clean::
rm -rf $(wildcard *.o *.d *.dSYM)

lldb/packages/Python/lldbsuite/test/lang/cpp/stl/Makefile

CXX_SOURCES := main.cpp CXX_SOURCES := main.cpp
CFLAGS := -g -O0 CFLAGS := -g -O0
clean: OBJECTS+=$(wildcard main.d.*)
include Makefile.rules include Makefile.rules

lldb/packages/Python/lldbsuite/test/lang/cpp/unicode-literals/Makefile

CXX_SOURCES := main.cpp CXX_SOURCES := main.cpp
CFLAGS := -g -O0 -std=c++11 CFLAGS := -g -O0 -std=c++11
clean: OBJECTS+=$(wildcard main.d.*)
include Makefile.rules include Makefile.rules

lldb/packages/Python/lldbsuite/test/lang/cpp/wchar_t/Makefile

CXX_SOURCES := main.cpp CXX_SOURCES := main.cpp
CFLAGS := -g -O0 CFLAGS := -g -O0
clean: OBJECTS+=$(wildcard main.d.*)
include Makefile.rules include Makefile.rules

lldb/packages/Python/lldbsuite/test/lang/objc/objc-ivar-stripped/Makefile

OBJC_SOURCES := main.m OBJC_SOURCES := main.m
LD_EXTRAS := -lobjc -framework Foundation LD_EXTRAS := -lobjc -framework Foundation
all: a.out.stripped all: a.out.stripped
a.out.stripped: a.out.dSYM a.out.stripped: a.out.dSYM
strip -o a.out.stripped a.out strip -o a.out.stripped a.out
clean::
rm -f a.out.stripped
rm -rf a.out.stripped.dSYM
include Makefile.rules include Makefile.rules

lldb/packages/Python/lldbsuite/test/lang/objc/objc-static-method-stripped/Makefile

OBJC_SOURCES := static.m OBJC_SOURCES := static.m
LD_EXTRAS := -lobjc -framework Foundation LD_EXTRAS := -lobjc -framework Foundation
default: a.out.stripped default: a.out.stripped
a.out.stripped: a.out.dSYM a.out.stripped: a.out.dSYM
strip -o a.out.stripped a.out strip -o a.out.stripped a.out
ln -sf a.out.dSYM a.out.stripped.dSYM ln -sf a.out.dSYM a.out.stripped.dSYM
clean::
rm -f a.out.stripped
rm -rf $(wildcard *.dSYM)
include Makefile.rules include Makefile.rules

lldb/packages/Python/lldbsuite/test/linux/add-symbols/Makefile

CXX_SOURCES := main.cpp CXX_SOURCES := main.cpp
LD_EXTRAS := -Wl,--build-id=none LD_EXTRAS := -Wl,--build-id=none
all: stripped.out all: stripped.out
stripped.out : a.out stripped.out : a.out
$(OBJCOPY) --remove-section=.note.gnu.build-id --remove-section=.gnu_debuglink --strip-debug $< $@ $(OBJCOPY) --remove-section=.note.gnu.build-id --remove-section=.gnu_debuglink --strip-debug $< $@
clean::
$(RM) stripped.out
include Makefile.rules include Makefile.rules

lldb/packages/Python/lldbsuite/test/linux/mix-dwo-and-regular-objects/Makefile

C_SOURCES := a.c b.c C_SOURCES := a.c b.c
a.o: CFLAGS_EXTRAS := -gsplit-dwarf a.o: CFLAGS_EXTRAS := -gsplit-dwarf
include Makefile.rules include Makefile.rules
.PHONY: clean
clean::
$(RM) -f a.dwo a.o b.o main

lldb/packages/Python/lldbsuite/test/linux/sepdebugsymlink/Makefile

C_SOURCES := main.c C_SOURCES := main.c
all: dirsymlink all: dirsymlink
dirreal: a.out dirreal: a.out
$(RM) -r $@ $(RM) -r $@
mkdir $@ mkdir $@
$(OBJCOPY) --only-keep-debug $< $@/stripped.debug $(OBJCOPY) --only-keep-debug $< $@/stripped.debug
$(OBJCOPY) --strip-all --add-gnu-debuglink=$@/stripped.debug $< $@/stripped.out $(OBJCOPY) --strip-all --add-gnu-debuglink=$@/stripped.debug $< $@/stripped.out
dirsymlink: dirreal dirsymlink: dirreal
$(RM) -r $@ $(RM) -r $@
mkdir $@ mkdir $@
ln -s ../$</stripped.out $@/stripped.symlink ln -s ../$</stripped.out $@/stripped.symlink
clean::
$(RM) -r dirreal dirsymlink
include Makefile.rules include Makefile.rules

lldb/packages/Python/lldbsuite/test/macosx/find-app-in-bundle/Makefile

Show All 9 Lines
all: TestApp.app/Contents/MacOS/TestApp all: TestApp.app/Contents/MacOS/TestApp
TestApp.app/Contents/MacOS/TestApp: $(SRCDIR)/main.c TestApp.app/Contents/MacOS/TestApp: $(SRCDIR)/main.c
$(CC) $(CFLAGS) -o TestApp $< $(CC) $(CFLAGS) -o TestApp $<
rm -rf TestApp.app rm -rf TestApp.app
cp -r $(SRCDIR)/TestApp.app . cp -r $(SRCDIR)/TestApp.app .
mv TestApp TestApp.app/Contents/MacOS/TestApp mv TestApp TestApp.app/Contents/MacOS/TestApp
mv TestApp.dSYM TestApp.app.dSYM mv TestApp.dSYM TestApp.app.dSYM
clean:
rm -rf TestApp.app/Contents/MacOS/TestApp TestApp.app.dSYM

lldb/packages/Python/lldbsuite/test/macosx/universal/Makefile

Show All 12 Lines
testit.x86_64: testit.x86_64.o testit.x86_64: testit.x86_64.o
$(CC) -arch x86_64 -o testit.x86_64 $< $(CC) -arch x86_64 -o testit.x86_64 $<
testit.x86_64h.o: main.c testit.x86_64h.o: main.c
$(CC) -g -O0 -arch x86_64h -c -o testit.x86_64h.o $< $(CC) -g -O0 -arch x86_64h -c -o testit.x86_64h.o $<
testit.x86_64.o: main.c testit.x86_64.o: main.c
$(CC) -g -O0 -arch x86_64 -c -o testit.x86_64.o $< $(CC) -g -O0 -arch x86_64 -c -o testit.x86_64.o $<
clean::
rm -rf $(wildcard testit* *~)

lldb/packages/Python/lldbsuite/test/python_api/findvalue_duplist/Makefile

CXX_SOURCES := main.cpp CXX_SOURCES := main.cpp
include Makefile.rules include Makefile.rules
# Clean renamed executable on 'make clean'
clean::
$(RM) -f no_synth

lldb/packages/Python/lldbsuite/test/python_api/formatters/Makefile

CXX_SOURCES := main.cpp CXX_SOURCES := main.cpp
include Makefile.rules include Makefile.rules
# Clean renamed executable on 'make clean'
clean::
$(RM) -f no_synth

lldb/packages/Python/lldbsuite/test/python_api/sbvalue_persist/Makefile

CXX_SOURCES := main.cpp CXX_SOURCES := main.cpp
# Clean renamed executable on 'make clean'
clean: OBJECTS+=no_synth
include Makefile.rules include Makefile.rules

lldb/packages/Python/lldbsuite/test/source-manager/Makefile

C_SOURCES := main-copy.c C_SOURCES := main-copy.c
include Makefile.rules include Makefile.rules
# Copy file into the build folder to enable the test to modify it. # Copy file into the build folder to enable the test to modify it.
main-copy.c: main.c main-copy.c: main.c
cp -f $< $@ cp -f $< $@
clean::
$(RM) main-copy.c