Page MenuHomePhabricator

[lldb] Remove all 'clean' targets from test Makefiles
ClosedPublic

Authored by teemperor on Thu, Feb 6, 6:10 AM.

Details

Summary

To my knowledge we don't actually use or need these rules. And if we need them then
there is probably a better way to implement this than having all these random regexes.

Diff Detail

Event Timeline

teemperor created this revision.Thu, Feb 6, 6:10 AM
Herald added a project: Restricted Project. · View Herald TranscriptThu, Feb 6, 6:10 AM
teemperor updated this revision to Diff 242899.Thu, Feb 6, 7:12 AM
  • Reverted some removal for bundle tests that somehow use this.
labath accepted this revision.Thu, Feb 6, 8:30 AM

Yes, I don't think we need to maintain this. Now that the tests our built out of tree, we can clean them by just nuking the build folder.

This revision is now accepted and ready to land.Thu, Feb 6, 8:30 AM
JDevlieghere accepted this revision.Thu, Feb 6, 9:33 AM
jingham added a subscriber: jingham.EditedThu, Feb 6, 11:15 AM

The one use I had for these clean targets was when you are making a new test and getting the test source to compile it is really tempting to run make in the test directory. It's a lot slower to go run the test, see the compile fail, fix something, etc... than just run make. But if you do that and don't clean, then when you actually go to run the test, it will fail because make sees the product in the source directory and won't build it in the out-of-line directory, but the test will look for it there.

Not a super compelling reason, but...

teemperor updated this revision to Diff 243106.Fri, Feb 7, 2:24 AM
  • Rebased
This revision was automatically updated to reflect the committed changes.