Page MenuHomePhabricator

[TSan] Ensure we can compile the runtime with older SDKs
ClosedPublic

Authored by yln on Feb 5 2020, 8:24 AM.

Details

Summary

One of my changes [1] included in this release silently bumped the
minimal macOS SDK required for building the TSan runtime to SDK 10.12.
Let's ensure release 10 does not unexpectedly break builders with old
SDKs and add proper minimal SDK checking in CMake for subsequent
releases.

This fix #ifdefs out interceptors for newer APIs. Note that the
resulting TSan runtime is less complete: when these newer APIs are used
TSan will report false positives.

Fixes llvm 10 release blocker: #44682
https://bugs.llvm.org/show_bug.cgi?id=44682

[1] 894abb46f891cba2e0ef581650f27f512a7824b4

Event Timeline

yln created this revision.Feb 5 2020, 8:24 AM
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptFeb 5 2020, 8:24 AM
Herald added subscribers: llvm-commits, Restricted Project. · View Herald Transcript
yln added a comment.Feb 5 2020, 8:30 AM

I can land this as soon as @dmajor confirms that it fixes their build.

dmajor accepted this revision.Feb 5 2020, 10:42 AM

The build was successful, thank you!

This revision is now accepted and ready to land.Feb 5 2020, 10:42 AM
yln closed this revision.Feb 5 2020, 11:22 AM

Manually closing revision. Automation picked up the commit but did not close this revision; maybe because the commit was to a release branch instead of master.