This is an archive of the discontinued LLVM Phabricator instance.

Add documentation on git bisecting across the MLIR merge.
ClosedPublic

Authored by thakis on Feb 4 2020, 12:45 PM.

Diff Detail

Event Timeline

thakis created this revision.Feb 4 2020, 12:45 PM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 4 2020, 12:45 PM
mehdi_amini accepted this revision.Feb 4 2020, 3:16 PM

Nice doc! Thanks.

llvm/docs/GitBisecting.rst
98

Why does it confuse git bisect? I would expect your run script to try ninja -C ../llvm-build-project clang || exit 125 and just skip the revisions?

108

Using directory filtering to drive the bisection and skip unrelated revisions seems like a good general recommendation independently of MLIR or merges.
Someone bisecting in lld for example could skip most revisions.

118

Seems like it answers my previous question (should this explanation be moved there?).

The part about git being confused about directories appearing and disappearing is a bit strange: surely there are many directories that will appear and disappear during the bisection?

This revision is now accepted and ready to land.Feb 4 2020, 3:16 PM
thakis marked 2 inline comments as done.Feb 10 2020, 11:23 AM

Thanks for the review, and sorry about dragging my feet -- my llvm repo was busy most of last week doing bisects :P

llvm/docs/GitBisecting.rst
98

I tried to reproduce the confused git bisect, but I only managed to do it if I hit ctrl-c during a bisect step. Let me replace this with a "don't hit ctrl-c while a bisect is running".

118

See above. I'll remove this paragraph.

This revision was automatically updated to reflect the committed changes.