Page MenuHomePhabricator

[SCEV][IndVars] Always provide insertion point to the SCEVExpander::isHighCostExpansion()

Authored by lebedev.ri on Jan 31 2020, 5:06 AM.



This addresses the llvm/test/Transforms/IndVarSimplify/elim-extend.ll @nestedIV regression from D73728

Diff Detail

Event Timeline

lebedev.ri created this revision.Jan 31 2020, 5:06 AM

Ping @reames / @mkazantsev
Please do indicate if there is any way i can help move this process along.

mkazantsev accepted this revision.Feb 24 2020, 10:13 PM

LGTM. Hope it doesn't end up exploding. :)


Should we assert that provided At is not null, or there are other places where it'd be OK?

This revision is now accepted and ready to land.Feb 24 2020, 10:13 PM
lebedev.ri marked 2 inline comments as done.Feb 25 2020, 10:18 AM

LGTM. Hope it doesn't end up exploding. :)

Thank you so much for reviewing this patch set!
We'll find out whether this explodes soon :)


Hm, such an assertion does not fail as of check-llvm, so let's do that.

lebedev.ri marked an inline comment as done.

Rebased, addressed review notes.