This is an archive of the discontinued LLVM Phabricator instance.

Make "process attach" command to support attaching to remote process in case if selected platform allows this.
ClosedPublic

Authored by ovyalov on Feb 2 2015, 1:50 PM.

Details

Reviewers
vharron
clayborg
Summary

Make "process attach" command to support attaching to remote process in case if selected platform allows.
If selected platform can debug a process use Platform::Attach otherwise fallback to Process::Attach.
Pass hijack_listener down to Platform::Attach in order to control when inferior transitions to stopped state/

Diff Detail

Event Timeline

ovyalov updated this revision to Diff 19187.Feb 2 2015, 1:50 PM
ovyalov retitled this revision from to Make "process attach" command to support attaching to remote process in case if selected platform allows this..
ovyalov updated this object.
ovyalov edited the test plan for this revision. (Show Details)
ovyalov added reviewers: clayborg, vharron.
ovyalov added a subscriber: Unknown Object (MLST).
clayborg accepted this revision.Feb 2 2015, 3:05 PM
clayborg edited edge metadata.

Looks good as long as all tests are passing.

This revision is now accepted and ready to land.Feb 2 2015, 3:05 PM