This is an archive of the discontinued LLVM Phabricator instance.

[CMake] Set ASM compiler for external projects
ClosedPublic

Authored by phosek on Jan 27 2020, 7:17 PM.

Details

Summary

This is necessary on Windows, otherwise CMake fails.

Diff Detail

Event Timeline

phosek created this revision.Jan 27 2020, 7:17 PM
Herald added a project: Restricted Project. · View Herald TranscriptJan 27 2020, 7:17 PM
smeenai accepted this revision.Jan 27 2020, 7:30 PM

I don't think it's conventional on Windows to use cl for assembly (you'd use ml or ml64 instead), but apparently CMake has a separate ASM_MASM mode for that, and clang-cl works fine for assembly, so LGTM.

This revision is now accepted and ready to land.Jan 27 2020, 7:30 PM
This revision was automatically updated to reflect the committed changes.