This is an archive of the discontinued LLVM Phabricator instance.

Differential D73343

[llvm-exegesis] Restrict the range of allowable rounding countrols.
ClosedPublic

Authored by courbet on Jan 24 2020, 3:56 AM.

Details

Reviewers
gchatelet
Commits
rG082dccac9079: [llvm-exegesis] Restrict the range of allowable rounding countrols.
Summary

It turns out that CUR_DIRECTION is just an internal placeholder, not an actual
valid encoded value.

Diff Detail

Event Timeline

courbet created this revision.Jan 24 2020, 3:56 AM
Herald added a project: Restricted Project. · View Herald TranscriptJan 24 2020, 3:56 AM
Herald added subscribers: mstojanovic, tschuett. · View Herald Transcript
Harbormaster completed remote builds in B44830: Diff 240152.Jan 24 2020, 3:58 AM
gchatelet accepted this revision.Jan 24 2020, 4:00 AM
This revision is now accepted and ready to land.Jan 24 2020, 4:00 AM
Closed by commit rG082dccac9079: [llvm-exegesis] Restrict the range of allowable rounding countrols. (authored by courbet). · Explain WhyFeb 3 2020, 2:55 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
llvm/
tools/
llvm-exegesis/
lib/
X86/
2 lines

Diff 242005

llvm/tools/llvm-exegesis/lib/X86/Target.cpp

Show First 20 Lines • Show All 645 Lines • ▼ Show 20 Lines
Error ExegesisX86Target::randomizeTargetMCOperand( Error ExegesisX86Target::randomizeTargetMCOperand(
const Instruction &Instr, const Variable &Var, MCOperand &AssignedValue, const Instruction &Instr, const Variable &Var, MCOperand &AssignedValue,
const BitVector &ForbiddenRegs) const { const BitVector &ForbiddenRegs) const {
const Operand &Op = Instr.getPrimaryOperand(Var); const Operand &Op = Instr.getPrimaryOperand(Var);
switch (Op.getExplicitOperandInfo().OperandType) { switch (Op.getExplicitOperandInfo().OperandType) {
case X86::OperandType::OPERAND_ROUNDING_CONTROL: case X86::OperandType::OPERAND_ROUNDING_CONTROL:
AssignedValue = AssignedValue =
MCOperand::createImm(randomIndex(X86::STATIC_ROUNDING::NO_EXC)); MCOperand::createImm(randomIndex(X86::STATIC_ROUNDING::TO_ZERO));
return Error::success(); return Error::success();
case X86::OperandType::OPERAND_COND_CODE: case X86::OperandType::OPERAND_COND_CODE:
AssignedValue = AssignedValue =
MCOperand::createImm(randomIndex(X86::CondCode::LAST_VALID_COND)); MCOperand::createImm(randomIndex(X86::CondCode::LAST_VALID_COND));
return Error::success(); return Error::success();
default: default:
break; break;
} }
▲ Show 20 Lines • Show All 92 Lines • Show Last 20 Lines