This is an archive of the discontinued LLVM Phabricator instance.

[llvm][TextAPI/MachO] Support writing single macCatalyst platform
ClosedPublic

Authored by JDevlieghere on Jan 23 2020, 9:52 PM.

Details

Summary

TAPI currently lacks a way to emit the macCatalyst platform. For TBD_V3 is does support zippered frameworks given that both macOS and macCatalyst are part of the PlatformSet.

Diff Detail

Event Timeline

JDevlieghere created this revision.Jan 23 2020, 9:52 PM
Herald added a project: Restricted Project. · View Herald TranscriptJan 23 2020, 9:52 PM

Unit tests: fail. 62150 tests passed, 5 failed and 811 were skipped.

failed: libc++.std/language_support/cmp/cmp_partialord/partialord.pass.cpp
failed: libc++.std/language_support/cmp/cmp_strongeq/cmp.strongeq.pass.cpp
failed: libc++.std/language_support/cmp/cmp_strongord/strongord.pass.cpp
failed: libc++.std/language_support/cmp/cmp_weakeq/cmp.weakeq.pass.cpp
failed: libc++.std/language_support/cmp/cmp_weakord/weakord.pass.cpp

clang-tidy: pass.

clang-format: pass.

Build artifacts: diff.json, clang-tidy.txt, clang-format.patch, CMakeCache.txt, console-log.txt, test-results.xml

Pre-merge checks is in beta. Report issue. Please join beta or enable it for your project.

JDevlieghere retitled this revision from [TAPI] Support macCatalyst in TBD_V4 to [TAPI] Support writing single macCatalyst platform.Jan 23 2020, 11:12 PM
JDevlieghere edited the summary of this revision. (Show Details)
JDevlieghere retitled this revision from [TAPI] Support writing single macCatalyst platform to [llvm][TextAPI/MachO] Support writing single macCatalyst platform.Jan 23 2020, 11:54 PM
cishida accepted this revision.Jan 27 2020, 8:06 AM

LGTM, thank you!

This revision is now accepted and ready to land.Jan 27 2020, 8:06 AM
This revision was automatically updated to reflect the committed changes.