Page MenuHomePhabricator

[Support][Windows] Re-enable dialog box disabling on MinGW
AcceptedPublic

Authored by jsroemer on Feb 2 2015, 12:34 AM.

Details

Reviewers
Bigcheese
Summary

D7230 completely removed dialog disabling for MinGW, although MinGW supports it with the proper settings (see D7224).

Todo: _CrtSetReportHook remains ifdef'ed out as for some reason dbghelp.h is not included for MinGW

Diff Detail

Event Timeline

jsroemer updated this revision to Diff 19131.Feb 2 2015, 12:34 AM
jsroemer retitled this revision from to [Support][Windows] Re-enable dialog box disabling on MinGW.
jsroemer updated this object.
jsroemer edited the test plan for this revision. (Show Details)
jsroemer added subscribers: rnk, Bigcheese, Unknown Object (MLST).
Bigcheese accepted this revision.Feb 2 2015, 12:39 AM
Bigcheese added a reviewer: Bigcheese.

lgtm

This revision is now accepted and ready to land.Feb 2 2015, 12:39 AM

Thanks for the review. As mentioned on the previous patch, I do not have commit access so someone else will have to land the patch.

Looks like patch was not committed.

Looks like patch was not committed.

True. It was never committed.