This is an archive of the discontinued LLVM Phabricator instance.

Differential D7330

[Support][Windows] Re-enable dialog box disabling on MinGW
AcceptedPublic

Authored by jsroemer on Feb 2 2015, 12:34 AM.

Details

Reviewers
Bigcheese
Summary

D7230 completely removed dialog disabling for MinGW, although MinGW supports it with the proper settings (see D7224).

Todo: _CrtSetReportHook remains ifdef'ed out as for some reason dbghelp.h is not included for MinGW

Diff Detail

Event Timeline

jsroemer updated this revision to Diff 19131.Feb 2 2015, 12:34 AM
jsroemer retitled this revision from to [Support][Windows] Re-enable dialog box disabling on MinGW.
jsroemer updated this object.
jsroemer edited the test plan for this revision. (Show Details)
jsroemer added subscribers: rnk, Bigcheese, Unknown Object (MLST).
Bigcheese accepted this revision.Feb 2 2015, 12:39 AM
Bigcheese added a reviewer: Bigcheese.

lgtm

This revision is now accepted and ready to land.Feb 2 2015, 12:39 AM
jsroemer added a comment.Feb 2 2015, 2:46 AM

Thanks for the review. As mentioned on the previous patch, I do not have commit access so someone else will have to land the patch.

Eugene.Zelenko added a subscriber: Eugene.Zelenko.Sep 28 2016, 2:47 PM

Looks like patch was not committed.

jsroemer added a comment.Sep 28 2016, 11:42 PM
In D7330#556054, @Eugene.Zelenko wrote:

Looks like patch was not committed.

True. It was never committed.

Revision Contents

PathSize
lib/
Support/
Windows/
7 lines

Diff 19131

lib/Support/Windows/Signals.inc

Context not available.
// Crash to stack trace handler on abort. // Crash to stack trace handler on abort.
signal(SIGABRT, HandleAbort); signal(SIGABRT, HandleAbort);
// The following functions are not reliably accessible on MinGW. // The following functions are only available on MinGW if a sufficiently
#ifdef _MSC_VER // current MSVCRT is used (the corresponding runtimes must be installed).
#if defined(_MSC_VER) || __MSVCRT_VERSION__ >= 0x900
// We're already handling writing a "something went wrong" message. // We're already handling writing a "something went wrong" message.
_set_abort_behavior(0, _WRITE_ABORT_MSG); _set_abort_behavior(0, _WRITE_ABORT_MSG);
// Disable Dr. Watson. // Disable Dr. Watson.
_set_abort_behavior(0, _CALL_REPORTFAULT); _set_abort_behavior(0, _CALL_REPORTFAULT);
#endif
#ifdef _MSC_VER
_CrtSetReportHook(AvoidMessageBoxHook); _CrtSetReportHook(AvoidMessageBoxHook);
#endif #endif
Context not available.