This is an archive of the discontinued LLVM Phabricator instance.

[RDA] Skip debug values
ClosedPublic

Authored by samparker on Jan 23 2020, 7:07 AM.

Details

Summary

Skip debug instructions when iterating through a block to find uses.

Diff Detail

Event Timeline

samparker created this revision.Jan 23 2020, 7:07 AM
Herald added a project: Restricted Project. · View Herald TranscriptJan 23 2020, 7:07 AM
Herald added a subscriber: hiraditya. · View Herald Transcript
samparker updated this revision to Diff 239904.Jan 23 2020, 7:41 AM

Using isDebugInstr instead.

Looks like a straightforward fix to me as top-level function processBasicBlock() skips over debug instructions, and this is consistent with that.

Just one question, one nit: the test case looks big to me, would it be easy to reduce it?

samparker updated this revision to Diff 239917.Jan 23 2020, 8:47 AM

Reduced test case.

SjoerdMeijer accepted this revision.Jan 23 2020, 8:49 AM

Thanks, LGTM

This revision is now accepted and ready to land.Jan 23 2020, 8:49 AM
This revision was automatically updated to reflect the committed changes.