Page MenuHomePhabricator

[AST] Add fixed-point subtraction constant evaluation.
AcceptedPublic

Authored by ebevhan on Jan 22 2020, 6:23 AM.

Details

Event Timeline

ebevhan created this revision.Jan 22 2020, 6:23 AM
Herald added a project: Restricted Project. · View Herald TranscriptJan 22 2020, 6:23 AM
Herald added a subscriber: cfe-commits. · View Herald Transcript
rjmccall accepted this revision.Jan 22 2020, 7:12 PM

LGTM other than the request to split the commit.

clang/include/clang/Basic/FixedPoint.h
82

These changes should probably be done in a separate patch.

I don't have a problem with compressing this type, but I'm curious if there was a concrete motivation.

This revision is now accepted and ready to land.Jan 22 2020, 7:12 PM
ebevhan marked an inline comment as done.Jan 23 2020, 12:12 AM
ebevhan added inline comments.
clang/include/clang/Basic/FixedPoint.h
82

I can do it separately.

There wasn't really a strong motivation other than that it could be packed better than it was.

ebevhan updated this revision to Diff 239791.Jan 23 2020, 12:26 AM

Move packing of FixedPointSemantics to a separate patch.

rjmccall accepted this revision.Jan 23 2020, 9:09 AM

LGTM.