This is an archive of the discontinued LLVM Phabricator instance.

Differential D73169

[llvm-readobj] - Add a test for --dyn-symbols when there are no dynamic symbols.
ClosedPublic

Authored by grimar on Jan 22 2020, 3:10 AM.

Details

Reviewers
jhenderson
MaskRay
• espindola
Commits
rG5c6f8f73ff81: [llvm-readobj] - Add a test for --dyn-symbols when there are no dynamic symbols.
Summary

It removes the Object/readobj-absent.test test and creates a one more case in
dyn-symbols.test we have.

Diff Detail

Event Timeline

grimar created this revision.Jan 22 2020, 3:10 AM
Herald added a reviewer: • espindola. · View Herald TranscriptJan 22 2020, 3:10 AM
Herald added a project: Restricted Project. · View Herald Transcript
Herald added subscribers: rupprecht, emaste. · View Herald Transcript
MaskRay added inline comments.Jan 22 2020, 11:42 AM
llvm/test/tools/llvm-readobj/ELF/dyn-symbols.test
297

| count 0

grimar updated this revision to Diff 239811.Jan 23 2020, 1:29 AM
grimar marked an inline comment as done.
grimar retitled this revision from [llvm-readobj] - Add a test for --dyn-symbols when there is no dynamic symbols. to [llvm-readobj] - Add a test for --dyn-symbols when there are no dynamic symbols..
  • Addressed review comments.
MaskRay added inline comments.Jan 23 2020, 9:12 PM
llvm/test/tools/llvm-readobj/ELF/dyn-symbols.test
294

does not have any dynamic symbols.

when the dynamic symbol table does not exist.

jhenderson added inline comments.Jan 24 2020, 12:41 AM
llvm/test/tools/llvm-readobj/ELF/dyn-symbols.test
294

That makes me think like we should have three different cases:

  1. Table does not exist.
  2. Table exists, but is size 0.
  3. Table exists, but only contains the null symbol.
grimar updated this revision to Diff 240154.Jan 24 2020, 4:04 AM
grimar marked 3 inline comments as done.
  • Addressed review comments.
llvm/test/tools/llvm-readobj/ELF/dyn-symbols.test
294

Done.

jhenderson accepted this revision.Jan 24 2020, 4:29 AM

LGTM.

This revision is now accepted and ready to land.Jan 24 2020, 4:29 AM
Closed by commit rG5c6f8f73ff81: [llvm-readobj] - Add a test for --dyn-symbols when there are no dynamic symbols. (authored by grimar). · Explain WhyJan 27 2020, 1:37 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
llvm/
test/
Object/
tools/
llvm-readobj/
ELF/
59 lines

Diff 240494

llvm/test/Object/readobj-absent.test

  • This file was deleted.
## Don't crash if required information is absent
# RUN: yaml2obj %s -o %t
# RUN: llvm-readobj --dyn-syms %t
--- !ELF
FileHeader:
Class: ELFCLASS32
Data: ELFDATA2LSB
Type: ET_REL
Machine: EM_386

llvm/test/tools/llvm-readobj/ELF/dyn-symbols.test

Show First 20 Lines • Show All 284 Lines • ▼ Show 20 Lines Entries:
VersionNdx: 3 VersionNdx: 3
Hash: 0 Hash: 0
Names: Names:
- NonDefault - NonDefault
DynamicSymbols: DynamicSymbols:
- Name: foo - Name: foo
- Name: bar - Name: bar
- Name: zed - Name: zed
## Case 8: Check what we print when:
MaskRayUnsubmitted
Done
ReplyInline Actions

does not have any dynamic symbols.

when the dynamic symbol table does not exist.

MaskRay: > does not have any dynamic symbols. when the dynamic symbol table does not exist.
jhendersonUnsubmitted
Done
ReplyInline Actions

That makes me think like we should have three different cases:

  1. Table does not exist.
  2. Table exists, but is size 0.
  3. Table exists, but only contains the null symbol.
jhenderson: That makes me think like we should have three different cases: 1) Table does not exist. 2)…
grimarAuthorUnsubmitted
Done
ReplyInline Actions

Done.

grimar: Done.
## a) The dynamic symbol table does not exist.
# RUN: yaml2obj %s --docnum=7 -o %t7
# RUN: llvm-readobj --dyn-symbols %t7 | FileCheck %s --check-prefix=NO-DYNSYM-LLVM
MaskRayUnsubmitted
Done
ReplyInline Actions

| count 0

MaskRay: `| count 0`
# RUN: llvm-readelf --dyn-symbols %t7 | count 0
## b) The dynamic symbol table has a size of 0.
# RUN: yaml2obj %s --docnum=8 -o %t8
# RUN: llvm-readobj --dyn-symbols %t8 | FileCheck %s --check-prefix=NO-DYNSYM-LLVM
# RUN: llvm-readelf --dyn-symbols %t8 | count 0
## c) The dynamic symbol table only contains the null symbol.
# RUN: yaml2obj %s --docnum=9 -o %t9
# RUN: llvm-readobj --dyn-symbols %t9 | FileCheck %s --check-prefix=DYNSYM-EMPTY-LLVM
# RUN: llvm-readelf --dyn-symbols %t9 | FileCheck %s --check-prefix=DYNSYM-EMPTY-GNU
# NO-DYNSYM-LLVM: DynamicSymbols [
# NO-DYNSYM-LLVM-NEXT: ]
# DYNSYM-EMPTY-LLVM: DynamicSymbols [
# DYNSYM-EMPTY-LLVM-NEXT: Symbol {
# DYNSYM-EMPTY-LLVM-NEXT: Name: (0)
# DYNSYM-EMPTY-LLVM-NEXT: Value: 0x0
# DYNSYM-EMPTY-LLVM-NEXT: Size: 0
# DYNSYM-EMPTY-LLVM-NEXT: Binding: Local (0x0)
# DYNSYM-EMPTY-LLVM-NEXT: Type: None (0x0)
# DYNSYM-EMPTY-LLVM-NEXT: Other: 0
# DYNSYM-EMPTY-LLVM-NEXT: Section: Undefined (0x0)
# DYNSYM-EMPTY-LLVM-NEXT: }
# DYNSYM-EMPTY-LLVM-NEXT: ]
# DYNSYM-EMPTY-GNU: Symbol table '.dynsym' contains 1 entries:
# DYNSYM-EMPTY-GNU-NEXT: Num: Value Size Type Bind Vis Ndx Name
# DYNSYM-EMPTY-GNU-NEXT: 0: 00000000 0 NOTYPE LOCAL DEFAULT UND
--- !ELF
FileHeader:
Class: ELFCLASS32
Data: ELFDATA2LSB
Type: ET_DYN
Machine: EM_386
--- !ELF
FileHeader:
Class: ELFCLASS32
Data: ELFDATA2LSB
Type: ET_DYN
Machine: EM_386
Sections:
- Name: .dynsym
Type: SHT_DYNSYM
Size: 0
--- !ELF
FileHeader:
Class: ELFCLASS32
Data: ELFDATA2LSB
Type: ET_DYN
Machine: EM_386
DynamicSymbols: []