This is an archive of the discontinued LLVM Phabricator instance.

Differential D73093

[llvm-readobj] - Remove rpath.test.
ClosedPublic

Authored by grimar on Jan 21 2020, 3:42 AM.

Details

Reviewers
jhenderson
MaskRay
• espindola
Commits
rG295aea807892: [llvm-readobj] - Remove rpath.test.
Summary

rpath.test checks that DT_RPATH is dumped.

We have dynamic-tags.test that tests all dynamic
tags and it is better, because also checks llvm-readelf
and does not use precompiled binaries.

Diff Detail

Event Timeline

grimar created this revision.Jan 21 2020, 3:42 AM
Herald added a reviewer: • espindola. · View Herald TranscriptJan 21 2020, 3:42 AM
Herald added a project: Restricted Project. · View Herald Transcript
Herald added subscribers: rupprecht, emaste. · View Herald Transcript
jhenderson accepted this revision.Jan 21 2020, 3:50 AM

LGTM.

This revision is now accepted and ready to land.Jan 21 2020, 3:50 AM
Closed by commit rG295aea807892: [llvm-readobj] - Remove rpath.test. (authored by grimar). · Explain WhyJan 21 2020, 5:18 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
llvm/
test/
tools/
llvm-readobj/
ELF/
Inputs/

Diff 239288

llvm/test/tools/llvm-readobj/ELF/Inputs/rpath.exe.elf-x86_64

  • This binary file was deleted.

llvm/test/tools/llvm-readobj/ELF/rpath.test

  • This file was deleted.
RUN: llvm-readobj --dynamic-table %p/Inputs/rpath.exe.elf-x86_64 \
RUN: | FileCheck %s
CHECK: 0x000000000000000F RPATH Library rpath: [/usr/local/lib]