This is an archive of the discontinued LLVM Phabricator instance.

Paths

[DWARF] Make dwarf::getUnitLengthFieldByteSize() constexpr. NFC.
ClosedPublic

Authored by ikudrin on Jan 20 2020, 5:28 AM.

Reviewers

Commits

Summary

This will help make some expressions in upcoming patches also constexpr.

LGTM

This revision is now accepted and ready to land.Jan 22 2020, 6:02 AM

Out of curiosity - is there any particular need/use for this function to be constexpr?

In D73036#1834734, @dblaikie wrote:

Out of curiosity - is there any particular need/use for this function to be constexpr?

Yes, this allowed converting some expressions in D71932 and D72900 from static const to constexpr.

This revision was automatically updated to reflect the committed changes.

Path

Size

llvm/

include/

llvm/

BinaryFormat/

2 lines

Show First 20 Lines • Show All 558 Lines • ▼ Show 20 Lines	uint8_t getDwarfOffsetByteSize() const {
}		}
llvm_unreachable("Invalid Format value");		llvm_unreachable("Invalid Format value");
}		}

explicit operator bool() const { return Version && AddrSize; }		explicit operator bool() const { return Version && AddrSize; }
};		};

/// Get the byte size of the unit length field depending on the DWARF format.		/// Get the byte size of the unit length field depending on the DWARF format.
inline uint8_t getUnitLengthFieldByteSize(DwarfFormat Format) {		constexpr uint8_t getUnitLengthFieldByteSize(DwarfFormat Format) {
switch (Format) {		switch (Format) {
case DwarfFormat::DWARF32:		case DwarfFormat::DWARF32:
return 4;		return 4;
case DwarfFormat::DWARF64:		case DwarfFormat::DWARF64:
return 12;		return 12;
}		}
llvm_unreachable("Invalid Format value");		llvm_unreachable("Invalid Format value");
}		}
▲ Show 20 Lines • Show All 108 Lines • Show Last 20 Lines