Page MenuHomePhabricator

[CMake] Handle 'Generic' system in HandleLLVMOptions.cmake
AcceptedPublic

Authored by JamesNagurne on Jan 17 2020, 12:47 PM.

Details

Reviewers
chandlerc
phosek
Summary
This configuration file is included in libcxx/libcxxabi/libunwind build
systems, which should be able to be built for embedded ARM, which is
considered a 'Generic' system (CMAKE_SYSTEM_NAME).

However, this file errors out when neither WIN32, UNIX, nor FUCHSIA is set.

I've defined the generic system as being neither WIN32, UNIX, and doesn't
have the shared library support for a link version script. Looking through
the applications of the variables defined, I couldn't see any conflicts
in the aforementioned projects.

Diff Detail

Event Timeline

JamesNagurne created this revision.Jan 17 2020, 12:47 PM
phosek accepted this revision.Jan 17 2020, 4:12 PM

LGTM

This revision is now accepted and ready to land.Jan 17 2020, 4:12 PM