Page MenuHomePhabricator

[scudo][standalone] WIP: make release interval configurable
AbandonedPublic

Authored by cryptoad on Jan 16 2020, 3:03 PM.

Details

Reviewers
None

Diff Detail

Event Timeline

cryptoad created this revision.Jan 16 2020, 3:03 PM
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptJan 16 2020, 3:03 PM
Herald added subscribers: llvm-commits, Restricted Project, jfb. · View Herald Transcript

Unit tests: pass. 61933 tests passed, 0 failed and 783 were skipped.

clang-tidy: unknown.

clang-format: pass.

Build artifacts: diff.json, clang-format.patch, CMakeCache.txt, console-log.txt, test-results.xml

eugenis added inline comments.
compiler-rt/lib/scudo/standalone/primary64.h
190

I don't think this release/acquire order does anything here. Replace with memory_order_relaxed?

compiler-rt/lib/scudo/standalone/wrappers_c.inc
162

This value, and the one below, do not seem to match the description in https://android.googlesource.com/platform/bionic/+/master/docs/native_allocator.md

A comment explaining the choice of the values would be great.

cryptoad marked an inline comment as done.Jan 22 2020, 9:52 AM
cryptoad added inline comments.
compiler-rt/lib/scudo/standalone/wrappers_c.inc
162

This CL is just a WIP that I put here to share with cferris@.
It will look different once we settle on what we need to do, you can ignore it :)
But thanks for the comments!

cryptoad abandoned this revision.Feb 3 2020, 9:23 AM