Page MenuHomePhabricator

Move DebugInfo to DebugInfo/DWARF
ClosedPublic

Authored by zturner on Jan 29 2015, 2:36 PM.

Details

Summary

In preparation for adding PDB support to LLVM, this moves the DWARF parsing code to its own subdirectory under DebugInfo, and renames LLVMDebugInfo to LLVMDebugInfoDWARF.

This is purely a mechanical / build system change.

I successfully built LLVM using CMake and ninja check-llvm returned no failures.

I'm not able to test the make/autoconf build, but I did update the relevant Makefiles, so I believe it should work.

[BTW, I know Frederic said he's working on a change that may conflict with this. I'm happy to wait until that change is in if people desire, but this was pretty mechanical and quick to whip up, so figured I would put it up in the meantime rather than wait around and do nothing :)]

Diff Detail

Repository
rL LLVM

Event Timeline

zturner updated this revision to Diff 18990.Jan 29 2015, 2:36 PM
zturner retitled this revision from to Move DebugInfo to DebugInfo/DWARF.
zturner updated this object.
zturner edited the test plan for this revision. (Show Details)
zturner added reviewers: aprantl, echristo, dblaikie, friss.
zturner added a subscriber: Unknown Object (MLST).
echristo edited edge metadata.Jan 30 2015, 9:21 AM

Couple of issues with the patch:

a) Doesn't build with make (bad change to lib/Makefile)
b) llvm-go bindings.

Zach is fixing these right now.

echristo accepted this revision.Jan 30 2015, 9:30 AM
echristo edited edge metadata.

Made the changes locally and retested. LGTM with those changes applied.

Thanks!

This revision is now accepted and ready to land.Jan 30 2015, 9:30 AM
This revision was automatically updated to reflect the committed changes.