[libc] Change test naming scheme

[abrachet]

Summary

This is an example for D72353 and is not meant to be reviewed.

libc/cmake/modules/LLVMLibCRules.cmake

function(add_redirector_library target_name)
 
   set_target_properties(
     ${target_name}
     PROPERTIES
       LINKER_LANGUAGE "C"
   )
 endfunction(add_redirector_library)
 
+function(get_suite_prefix name)
+  string(REPLACE "${LIBC_SOURCE_DIR}/" "" relative_path ${CMAKE_CURRENT_SOURCE_DIR})
+  string(REPLACE "/" "." dotted_path ${relative_path})
+  set(${name} libc.${dotted_path} PARENT_SCOPE)
+endfunction(get_suite_prefix)
+
+function(get_suite_name name)
+  get_suite_prefix(prefix)
+  set(${name} ${prefix}.all PARENT_SCOPE)
+endfunction(get_suite_name)
+
 # Rule to add a gtest unittest.
 # Usage
 #    add_libc_unittest(
 #      <target name>
 #      SUITE <name of the suite this test belongs to>
 #      SRCS  <list of .cpp files for the test>
 #      HDRS  <list of .h files for the test>
 #      DEPENDS <list of dependencies>
 #    )
 function(add_libc_unittest target_name)
   if(NOT LLVM_INCLUDE_TESTS)
     return()
   endif()
 
+  get_suite_prefix(prefix)
+  set(target_name "${prefix}.${target_name}")
+
   cmake_parse_arguments(
     "LIBC_UNITTEST"
     "" # No optional arguments
-    "SUITE" # Single value arguments
+    "" # Single value arguments
     "SRCS;HDRS;DEPENDS" # Multi-value arguments
     ${ARGN}
   )
   if(NOT LIBC_UNITTEST_SRCS)
     message(FATAL_ERROR "'add_libc_unittest' target requires a SRCS list of .cpp files.")
   endif()
   if(NOT LIBC_UNITTEST_DEPENDS)
     message(FATAL_ERROR "'add_libc_unittest' target requires a DEPENDS list of 'add_entrypoint_object' targets.")
   endif()
 
+  get_suite_name(SUITE_NAME)
+  set(LIBC_UNITTEST_SUITE ${SUITE_NAME})
+
   set(library_deps "")
   foreach(dep IN LISTS LIBC_UNITTEST_DEPENDS)
     get_target_property(dep_type ${dep} "TARGET_TYPE")
     if (dep_type)
       string(COMPARE EQUAL ${dep_type} ${ENTRYPOINT_OBJ_TARGET_TYPE} dep_is_entrypoint)
       if(dep_is_entrypoint)
         get_target_property(obj_file ${dep} "OBJECT_FILE_RAW")
         list(APPEND library_deps ${obj_file})
function(add_libc_unittest target_name)
   )
   if(LIBC_UNITTEST_SUITE)
     add_dependencies(
       ${LIBC_UNITTEST_SUITE}
       ${target_name}
     )
   endif()
 endfunction(add_libc_unittest)
+
+function(libc_create_suite)
+  get_suite_name(suite)
+  add_custom_target(${suite})
+  add_dependencies(check-libc ${suite})
+endfunction(libc_create_suite)

libc/test/CMakeLists.txt

-add_custom_target(check_libc)
+add_custom_target(check-libc)
 
 add_subdirectory(config)
 add_subdirectory(src)

libc/test/config/linux/CMakeLists.txt

 add_custom_target(libc_linux_tests)
-add_dependencies(check_libc libc_linux_tests)
+add_dependencies(check-libc libc_linux_tests)
 
 add_subdirectory(x86_64)

libc/test/config/linux/x86_64/CMakeLists.txt

-add_custom_target(libc_linux_x86_64_tests)
-add_dependencies(libc_linux_tests libc_linux_x86_64_tests)
+libc_create_suite()
 
 add_libc_unittest(
-  libc_linux_x86_64_syscall_unittest
-  SUITE libc_linux_x86_64_tests
-  SRCS syscall_test.cpp
+  syscall_test
+  SRCS
+    syscall_test.cpp
   DEPENDS
    syscall_impl_h
    support_common_h
 )

libc/test/src/errno/CMakeLists.txt

-add_custom_target(libc_errno_unittests)
-add_dependencies(check_libc libc_errno_unittests)
+libc_create_suite()
 
 add_libc_unittest(
   errno_test
-  SUITE
-    libc_errno_unittests
   SRCS
     errno_test.cpp
   DEPENDS
     __errno_location
 )

libc/test/src/string/CMakeLists.txt

-add_custom_target(libc_string_unittests)
-add_dependencies(check_libc libc_string_unittests)
-
+libc_create_suite()
 add_libc_unittest(
   strcat_test
-  SUITE
-    libc_string_unittests
   SRCS
     strcat_test.cpp
   DEPENDS
     strcat
     strcpy
 )
 
 add_libc_unittest(
   strcpy_test
-  SUITE
-    libc_string_unittests
   SRCS
     strcpy_test.cpp
   DEPENDS
     strcpy
 )

libc/test/src/sys/mman/CMakeLists.txt

-add_custom_target(libc_sys_mman_unittests)
-add_dependencies(check_libc libc_sys_mman_unittests)
+libc_create_suite()
 
 add_libc_unittest(
   mmap_test
-  SUITE
-    libc_sys_mman_unittests
   SRCS
     mmap_test.cpp
   DEPENDS
     mmap
     munmap
     __errno_location
 )