|14–15 ↗||(On Diff #18873)|
Please use multiple FileCheck prefixes to handle things that are the same for both commands.
|16 ↗||(On Diff #18873)|
As mentioned in D6774, we can significantly simplify this using arguments and returns.
As noted there, I don't mind if this is part of the big cleanup.
|50–51 ↗||(On Diff #18873)|
It's possible to shave off one instruction here. At the moment this code is equivalent to this expression:
R = (X << 24) | (X >> 24) | ((X >> 8) & 0xFF00) | ((X << 8) & 0xFF0000)
The '& 0xFF0000' requires an lui+and but with a slight change to the expression we could use an andi instead:
R = (X << 24) | (X >> 24) | ((X >> 8) & 0xFF00) | ((X & 0xFF00) << 8)
|66–103 ↗||(On Diff #18873)|