Page MenuHomePhabricator

[mlir] Fix indexed_accessor_range to properly forward the derived class.
ClosedPublic

Authored by rriddle on Jan 2 2020, 9:58 PM.

Details

Summary

This fixes the return value of helper methods on the base range class.

Diff Detail

Event Timeline

rriddle created this revision.Jan 2 2020, 9:58 PM
Herald added a project: Restricted Project. · View Herald TranscriptJan 2 2020, 9:58 PM

Unit tests: pass. 61173 tests passed, 0 failed and 729 were skipped.

clang-tidy: fail. Please fix clang-tidy findings.

clang-format: pass.

Build artifacts: diff.json, clang-tidy.txt, clang-format.patch, CMakeCache.txt, console-log.txt, test-results.xml

jpienaar accepted this revision.Jan 3 2020, 8:11 AM

Could we add a test that this would have hit? (I'm thinking of one just assigning the sliced/drop_front one).

This revision is now accepted and ready to land.Jan 3 2020, 8:11 AM
rriddle updated this revision to Diff 236102.Jan 3 2020, 11:57 AM

Add test file.

Unit tests: pass. 61236 tests passed, 0 failed and 729 were skipped.

clang-tidy: fail. Please fix clang-tidy findings.

clang-format: pass.

Build artifacts: diff.json, clang-tidy.txt, clang-format.patch, CMakeCache.txt, console-log.txt, test-results.xml

This revision was automatically updated to reflect the committed changes.