Also fix some bugs in the testcases which this exposed.
Details
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
Unit tests: pass. 61162 tests passed, 0 failed and 728 were skipped.
clang-tidy: pass.
clang-format: pass.
Build artifacts: diff.json, clang-tidy.txt, clang-format.patch, CMakeCache.txt, console-log.txt, test-results.xml
Unit tests: pass. 61163 tests passed, 0 failed and 728 were skipped.
clang-tidy: pass.
clang-format: pass.
Build artifacts: diff.json, clang-tidy.txt, clang-format.patch, CMakeCache.txt, console-log.txt, test-results.xml
Thanks!
clang-tools-extra/clangd/unittests/XRefsTests.cpp | ||
---|---|---|
519 | nit: I would rather keep the loop and just use ADD_FAILURE() instead of llvm::errs(). | |
573 | nit: this one can be dropped. | |
577 | nit: this looks like an overkill to me, in the end we are trying to test hover behavior, not diagnostics. I would drop the whole loop here. |
Unit tests: pass. 61301 tests passed, 0 failed and 736 were skipped.
clang-tidy: pass.
clang-format: pass.
Build artifacts: diff.json, clang-tidy.txt, clang-format.patch, CMakeCache.txt, console-log.txt, test-results.xml
nit: I would rather turn this into a declaration.