This is an archive of the discontinued LLVM Phabricator instance.

Differential D72005

Check for aarch64 when not using .init_arrays
ClosedPublic

Authored by saugustine on Dec 30 2019, 8:21 AM.

Details

Reviewers
vvereschaka
Commits
rG108daf76118e: Check for aarch64 when not using .init_arrays

Diff Detail

Event Timeline

saugustine created this revision.Dec 30 2019, 8:21 AM
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptDec 30 2019, 8:21 AM
Herald added subscribers: llvm-commits, Restricted Project, kristof.beyls. · View Herald Transcript
Harbormaster completed remote builds in B43050: Diff 235606.Dec 30 2019, 8:23 AM
vvereschaka accepted this revision.Dec 30 2019, 8:14 PM

Thank you Sterling.
LGTM

This revision is now accepted and ready to land.Dec 30 2019, 8:14 PM
saugustine closed this revision.Jan 2 2020, 10:19 AM

Committed as 108daf76118e5b97696f58386d0b48d4b858ffad

Revision Contents

PathSize
compiler-rt/
lib/
crt/
4 lines

Diff 235606

compiler-rt/lib/crt/crtbegin.c

Show First 20 Lines • Show All 46 Lines • ▼ Show 20 Lines
#ifdef CRT_HAS_INITFINI_ARRAY #ifdef CRT_HAS_INITFINI_ARRAY
__attribute__((section(".init_array"), __attribute__((section(".init_array"),
used)) static void (*__init)(void) = __do_init; used)) static void (*__init)(void) = __do_init;
#elif defined(__i386__) || defined(__x86_64__) #elif defined(__i386__) || defined(__x86_64__)
__asm__(".pushsection .init,\"ax\",@progbits\n\t" __asm__(".pushsection .init,\"ax\",@progbits\n\t"
"call " __USER_LABEL_PREFIX__ "__do_init\n\t" "call " __USER_LABEL_PREFIX__ "__do_init\n\t"
".popsection"); ".popsection");
#elif defined(__arm__) #elif defined(__arm__) || defined(__aarch64__)
__asm__(".pushsection .init,\"ax\",%progbits\n\t" __asm__(".pushsection .init,\"ax\",%progbits\n\t"
"bl " __USER_LABEL_PREFIX__ "__do_init\n\t" "bl " __USER_LABEL_PREFIX__ "__do_init\n\t"
".popsection"); ".popsection");
#elif defined(__powerpc__) || defined(__powerpc64__) #elif defined(__powerpc__) || defined(__powerpc64__)
__asm__(".pushsection .init,\"ax\",@progbits\n\t" __asm__(".pushsection .init,\"ax\",@progbits\n\t"
"bl " __USER_LABEL_PREFIX__ "__do_init\n\t" "bl " __USER_LABEL_PREFIX__ "__do_init\n\t"
"nop\n\t" "nop\n\t"
".popsection"); ".popsection");
Show All 32 Lines
#ifdef CRT_HAS_INITFINI_ARRAY #ifdef CRT_HAS_INITFINI_ARRAY
__attribute__((section(".fini_array"), __attribute__((section(".fini_array"),
used)) static void (*__fini)(void) = __do_fini; used)) static void (*__fini)(void) = __do_fini;
#elif defined(__i386__) || defined(__x86_64__) #elif defined(__i386__) || defined(__x86_64__)
__asm__(".pushsection .fini,\"ax\",@progbits\n\t" __asm__(".pushsection .fini,\"ax\",@progbits\n\t"
"call " __USER_LABEL_PREFIX__ "__do_fini\n\t" "call " __USER_LABEL_PREFIX__ "__do_fini\n\t"
".popsection"); ".popsection");
#elif defined(__arm__) #elif defined(__arm__) || defined(__aarch64__)
__asm__(".pushsection .fini,\"ax\",%progbits\n\t" __asm__(".pushsection .fini,\"ax\",%progbits\n\t"
"bl " __USER_LABEL_PREFIX__ "__do_fini\n\t" "bl " __USER_LABEL_PREFIX__ "__do_fini\n\t"
".popsection"); ".popsection");
#elif defined(__powerpc__) || defined(__powerpc64__) #elif defined(__powerpc__) || defined(__powerpc64__)
__asm__(".pushsection .fini,\"ax\",@progbits\n\t" __asm__(".pushsection .fini,\"ax\",@progbits\n\t"
"bl " __USER_LABEL_PREFIX__ "__do_fini\n\t" "bl " __USER_LABEL_PREFIX__ "__do_fini\n\t"
"nop\n\t" "nop\n\t"
".popsection"); ".popsection");
#elif defined(__sparc__) #elif defined(__sparc__)
__asm__(".pushsection .fini,\"ax\",@progbits\n\t" __asm__(".pushsection .fini,\"ax\",@progbits\n\t"
"call " __USER_LABEL_PREFIX__ "__do_fini\n\t" "call " __USER_LABEL_PREFIX__ "__do_fini\n\t"
".popsection"); ".popsection");
#else #else
#error "crtbegin without .init_fini array unimplemented for this architecture" #error "crtbegin without .init_fini array unimplemented for this architecture"
#endif // CRT_HAS_INIT_FINI_ARRAY #endif // CRT_HAS_INIT_FINI_ARRAY