This is an archive of the discontinued LLVM Phabricator instance.

[NFC][LoopFusion] Fix printing of the guard branch.
ClosedPublic

Authored by Whitney on Dec 25 2019, 9:55 AM.

Download Raw Diff

Details

Reviewers

kbarton
jdoerfert

Summary

getName() of a BranchInst is the empty string, because it doesn't have a return value.

Diff Detail

Repository: rG LLVM Github Monorepo

Event Timeline

Whitney created this revision.Dec 25 2019, 9:55 AM

Herald added subscribers: llvm-commits, hiraditya. · View Herald TranscriptDec 25 2019, 9:55 AM

LGTM.

This revision is now accepted and ready to land.Dec 25 2019, 3:09 PM

https://reviews.llvm.org/rGd1f41b2ca999

Revision Contents

Path

Size

llvm/

lib/

Transforms/

Scalar/

LoopFuse.cpp

8 lines

Diff 235288

llvm/lib/Transforms/Scalar/LoopFuse.cpp

Show First 20 Lines • Show All 251 Lines • ▼ Show 20 Lines	assert(GuardBranch->isConditional() &&
"Expecting guard to be a conditional branch.");		"Expecting guard to be a conditional branch.");
return (GuardBranch->getSuccessor(0) == Preheader)		return (GuardBranch->getSuccessor(0) == Preheader)
? GuardBranch->getSuccessor(1)		? GuardBranch->getSuccessor(1)
: GuardBranch->getSuccessor(0);		: GuardBranch->getSuccessor(0);
}		}

#if !defined(NDEBUG) \|\| defined(LLVM_ENABLE_DUMP)		#if !defined(NDEBUG) \|\| defined(LLVM_ENABLE_DUMP)
LLVM_DUMP_METHOD void dump() const {		LLVM_DUMP_METHOD void dump() const {
dbgs() << "\tGuardBranch: "		dbgs() << "\tGuardBranch: ";
<< (GuardBranch ? GuardBranch->getName() : "nullptr") << "\n"		if (GuardBranch)
		dbgs() << *GuardBranch;
		else
		dbgs() << "nullptr";
		dbgs() << "\n"
<< "\tPreheader: " << (Preheader ? Preheader->getName() : "nullptr")		<< "\tPreheader: " << (Preheader ? Preheader->getName() : "nullptr")
<< "\n"		<< "\n"
<< "\tHeader: " << (Header ? Header->getName() : "nullptr") << "\n"		<< "\tHeader: " << (Header ? Header->getName() : "nullptr") << "\n"
<< "\tExitingBB: "		<< "\tExitingBB: "
<< (ExitingBlock ? ExitingBlock->getName() : "nullptr") << "\n"		<< (ExitingBlock ? ExitingBlock->getName() : "nullptr") << "\n"
<< "\tExitBB: " << (ExitBlock ? ExitBlock->getName() : "nullptr")		<< "\tExitBB: " << (ExitBlock ? ExitBlock->getName() : "nullptr")
<< "\n"		<< "\n"
<< "\tLatch: " << (Latch ? Latch->getName() : "nullptr") << "\n"		<< "\tLatch: " << (Latch ? Latch->getName() : "nullptr") << "\n"
▲ Show 20 Lines • Show All 1,398 Lines • Show Last 20 Lines