Page MenuHomePhabricator

[docs] Remove `git llvm push` and `git llvm revert` from GettingStarted
ClosedPublic

Authored by bogner on Dec 17 2019, 5:13 PM.

Details

Summary

These sections aren't accurate since the github move.

Diff Detail

Event Timeline

bogner created this revision.Dec 17 2019, 5:13 PM
Herald added a project: Restricted Project. · View Herald TranscriptDec 17 2019, 5:13 PM
echristo accepted this revision.Dec 17 2019, 5:15 PM

LGTM.

-eric

This revision is now accepted and ready to land.Dec 17 2019, 5:15 PM
mehdi_amini added inline comments.
llvm/docs/GettingStarted.rst
494

You're using "commit" in a fairly liberal way. Since we're native Git now, can we adjust the vocabulary?

Once a patch is reviewed, you can commit it in your local clone of the repository in the master branch, and use `git push` to push it to the upstream repository on GitHub. You may need to run `git pull --rebase` in case other changes have been pushed in the meantime.

Note that LLVM currently has a linear-history policy, which means that merge commits are
not allowed. The `llvm-project` repository on GitHub is configured to reject pushes
that include merges, so make sure to use `--rebase` when you pull. Alternatively you can
do once `git config --global pull.rebase true` to make it the default on your system.
bogner marked an inline comment as done.Jan 23 2020, 10:11 AM
bogner added inline comments.
llvm/docs/GettingStarted.rst
494

Seems reasonable. Do you want to make this change or shall I?