Page MenuHomePhabricator

[SystemZ] Improve handling of "packed-stack" function attribute.
AbandonedPublic

Authored by jonpa on Dec 16 2019, 11:32 AM.

Details

Reviewers
uweigand
Summary

Instead of just calling hasFnAttribute(), call getFnAttribute() and check that it is set to "true".

It seems that the "backchain" attribute does not have to be checked this way, since it is simply present or non-present. Would this be preferrable perhaps also for "packed-stack" (instead of this patch)?

Diff Detail

Event Timeline

jonpa created this revision.Dec 16 2019, 11:32 AM
Herald added a project: Restricted Project. · View Herald TranscriptDec 16 2019, 11:32 AM

It seems that the "backchain" attribute does not have to be checked this way, since it is simply present or non-present. Would this be preferrable perhaps also for "packed-stack" (instead of this patch)?

Ah yes, I think that would be the best solution. Thanks!

jonpa abandoned this revision.Dec 17 2019, 10:02 AM

It seems that the "backchain" attribute does not have to be checked this way, since it is simply present or non-present. Would this be preferrable perhaps also for "packed-stack" (instead of this patch)?

Ah yes, I think that would be the best solution. Thanks!

OK - closing this, then.