Page MenuHomePhabricator

[RISCV] Don't crash on unsupported relocations
ClosedPublic

Authored by luismarques on Dec 16 2019, 3:34 AM.

Details

Summary

Instead of crashing due to the llvm_unreachable, provide a proper error when invalid fixups/relocs are encountered.

Diff Detail

Event Timeline

luismarques created this revision.Dec 16 2019, 3:34 AM
asb requested changes to this revision.Dec 16 2019, 6:07 AM

Please update the check so it checks the error location too, like we do for other *invalid.s checks.

This revision now requires changes to proceed.Dec 16 2019, 6:07 AM

Update test CHECKs to check for line number/columns.

Add RUN line for riscv64

asb accepted this revision.Dec 19 2019, 7:05 AM

LGTM, thanks.

This revision is now accepted and ready to land.Dec 19 2019, 7:05 AM
This revision was automatically updated to reflect the committed changes.