This is an archive of the discontinued LLVM Phabricator instance.

Differential D71297

Remove unsound caching in LanguageCategory
ClosedPublic

Authored by aprantl on Dec 10 2019, 1:28 PM.

Details

Reviewers
jingham
davide
Commits
rG2fb07b90dc1c: Remove unsound caching in LanguageCategory
Summary

Analogous to https://reviews.llvm.org/D71233 it is not safe to cache something that depends on the actual ValueObject in a cache then keys only off the type name.

Diff Detail

Event Timeline

aprantl created this revision.Dec 10 2019, 1:28 PM
aprantl added a parent revision: D71296: Replace redundant code in LanguageCategory with templates (NFC).
davide accepted this revision.Dec 10 2019, 3:55 PM

LGTM.

This revision is now accepted and ready to land.Dec 10 2019, 3:55 PM
Closed by commit rG2fb07b90dc1c: Remove unsound caching in LanguageCategory (authored by aprantl). · Explain WhyDec 10 2019, 4:18 PM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptDec 10 2019, 4:18 PM

Revision Contents

PathSize
lldb/
source/
DataFormatters/
4 lines

Diff 233223

lldb/source/DataFormatters/LanguageCategory.cpp

Show First 20 Lines • Show All 104 Lines • ▼ Show 20 Linesbool LanguageCategory::GetHardcoded(FormatManager &fmt_mgr,
lldb::DynamicValueType use_dynamic(match_data.GetDynamicValueType()); lldb::DynamicValueType use_dynamic(match_data.GetDynamicValueType());
for (auto &candidate : GetHardcodedFinder<ImplSP>()) { for (auto &candidate : GetHardcodedFinder<ImplSP>()) {
if (auto result = candidate(valobj, use_dynamic, fmt_mgr)) { if (auto result = candidate(valobj, use_dynamic, fmt_mgr)) {
retval_sp = result; retval_sp = result;
break; break;
} }
} }
if (match_data.GetTypeForCache() &&
(!retval_sp || !retval_sp->NonCacheable())) {
m_format_cache.Set(match_data.GetTypeForCache(), retval_sp);
}
return (bool)retval_sp; return (bool)retval_sp;
} }
/// Explicit instantiations for the four types. /// Explicit instantiations for the four types.
/// \{ /// \{
template bool LanguageCategory::GetHardcoded<lldb::TypeValidatorImplSP>( template bool LanguageCategory::GetHardcoded<lldb::TypeValidatorImplSP>(
FormatManager &, FormattersMatchData &, lldb::TypeValidatorImplSP &); FormatManager &, FormattersMatchData &, lldb::TypeValidatorImplSP &);
template bool LanguageCategory::GetHardcoded<lldb::TypeFormatImplSP>( template bool LanguageCategory::GetHardcoded<lldb::TypeFormatImplSP>(
Show All 26 Lines