Page MenuHomePhabricator

Remove unsound caching in LanguageCategory
ClosedPublic

Authored by aprantl on Dec 10 2019, 1:28 PM.

Details

Summary

Analogous to https://reviews.llvm.org/D71233 it is not safe to cache something that depends on the actual ValueObject in a cache then keys only off the type name.

Diff Detail

Event Timeline

davide accepted this revision.Dec 10 2019, 3:55 PM

LGTM.

This revision is now accepted and ready to land.Dec 10 2019, 3:55 PM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptDec 10 2019, 4:18 PM