This is an archive of the discontinued LLVM Phabricator instance.

[BPF] put not-section-attribute externs into BTF ".extern" data section
ClosedPublic

Authored by yonghong-song on Dec 10 2019, 11:14 AM.

Details

Reviewers
ast
anakryiko
Summary

Currently for extern variables with section attribute, those
BTF_KIND_VARs will not be placed in any DataSec. This is
inconvenient as any other generated BTF_KIND_VAR belongs to
one DataSec. This patch put these extern variables into
".extern" section so bpf loader can have a consistent
processing mechanism for all data sections and variables.

Diff Detail

Event Timeline

yonghong-song created this revision.Dec 10 2019, 11:14 AM
Herald added a project: Restricted Project. · View Herald TranscriptDec 10 2019, 11:14 AM
anakryiko accepted this revision.Dec 10 2019, 11:20 AM

awesome, thanks!

This revision is now accepted and ready to land.Dec 10 2019, 11:20 AM
ast accepted this revision.Dec 10 2019, 11:21 AM

lgtm as well