This is an archive of the discontinued LLVM Phabricator instance.

[lldb][test] Create a separate LLDB_TEST_SRC var to allow moving tests.
ClosedPublic

Authored by rupprecht on Dec 6 2019, 2:57 PM.

Details

Summary

This creates a separate LLDB_TEST_SRC var to match the existing LLDB_TEST var. LLDB_TEST points to the test framework, LLDB_TEST_SRC points to the tests themselves.

The var points to the same place, but a future patch will move the tree + update var.

Diff Detail

Event Timeline

rupprecht created this revision.Dec 6 2019, 2:57 PM
Herald added a project: Restricted Project. · View Herald TranscriptDec 6 2019, 2:57 PM

Build result: pass - 60563 tests passed, 0 failed and 726 were skipped.

Log files: console-log.txt, CMakeCache.txt

Hmm... given the lua thread on lldb-dev, maybe we should slow down here, and consider the potential relationship of these tests and the hypothetical lua tests that come to be. One of the reasons the current tests are so deeply nested was that Zach was trying to future-proof ourselves for addition of new scripting languages (at that time, Java was being floated around, but the idea never took off the ground). I'd hate to move these tests now, only to have to move them around again in a couple of weeks to make room for lua...

Hmm... given the lua thread on lldb-dev, maybe we should slow down here, and consider the potential relationship of these tests and the hypothetical lua tests that come to be. One of the reasons the current tests are so deeply nested was that Zach was trying to future-proof ourselves for addition of new scripting languages (at that time, Java was being floated around, but the idea never took off the ground). I'd hate to move these tests now, only to have to move them around again in a couple of weeks to make room for lua...

I don't *think* this patch is affected by that discussion, except for the speculative comment to update lldb_test_root = os.path.join(lldb_root, "test", "API", "test") with the next patch. I'll followup with the next patch discussion.

labath accepted this revision.Dec 11 2019, 2:02 AM

Hmm... given the lua thread on lldb-dev, maybe we should slow down here, and consider the potential relationship of these tests and the hypothetical lua tests that come to be. One of the reasons the current tests are so deeply nested was that Zach was trying to future-proof ourselves for addition of new scripting languages (at that time, Java was being floated around, but the idea never took off the ground). I'd hate to move these tests now, only to have to move them around again in a couple of weeks to make room for lua...

I don't *think* this patch is affected by that discussion, except for the speculative comment to update lldb_test_root = os.path.join(lldb_root, "test", "API", "test") with the next patch. I'll followup with the next patch discussion.

Yes, that seems reasonable.

This revision is now accepted and ready to land.Dec 11 2019, 2:02 AM
rupprecht marked an inline comment as done.Feb 7 2020, 3:09 PM
rupprecht added inline comments.
lldb/packages/Python/lldbsuite/__init__.py
32

... I'm finally planning to submit this (checking now that the patch still passes), with an updated path based on D71151.

This patch is intended to be NFC, I'll retitle it when submitting.

JDevlieghere accepted this revision.Feb 7 2020, 3:26 PM
This revision was automatically updated to reflect the committed changes.