This is an archive of the discontinued LLVM Phabricator instance.

Differential D71146

[llvm][VFABI] Add more testing for LLVM internal mangling.
ClosedPublic

Authored by fpetrogalli on Dec 6 2019, 12:48 PM.

Details

Reviewers
andwar
Commits
rG2ea6ab67779d: [llvm][VFABI] Add more testing for LLVM internal mangling.
Summary

The tests cover the internal mangling for:

  1. Masked signatures.
  2. Scalable signatures.
  3. Masked scalable signatures with linear.

Diff Detail

Event Timeline

fpetrogalli created this revision.Dec 6 2019, 12:48 PM
Herald added a project: Restricted Project. · View Herald TranscriptDec 6 2019, 12:48 PM
Herald added a subscriber: llvm-commits. · View Herald Transcript
Harbormaster completed remote builds in B42033: Diff 232632.Dec 6 2019, 12:52 PM
andwar accepted this revision.Dec 9 2019, 1:14 AM

LGTM

This revision is now accepted and ready to land.Dec 9 2019, 1:14 AM
Closed by commit rG2ea6ab67779d: [llvm][VFABI] Add more testing for LLVM internal mangling. (authored by fpetrogalli). · Explain WhyDec 9 2019, 7:57 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
llvm/
unittests/
Analysis/
39 lines

Diff 232632

llvm/unittests/Analysis/VectorFunctionABITest.cpp

Show First 20 Lines • Show All 441 Lines • ▼ Show 20 LinesTEST_F(VFABIParserTest, ParseMaskingAVX512) {
EXPECT_FALSE(IsScalable); EXPECT_FALSE(IsScalable);
EXPECT_EQ(ISA, VFISAKind::AVX512); EXPECT_EQ(ISA, VFISAKind::AVX512);
EXPECT_EQ(Parameters.size(), (unsigned)2); EXPECT_EQ(Parameters.size(), (unsigned)2);
EXPECT_EQ(Parameters[0], VFParameter({0, VFParamKind::Vector})); EXPECT_EQ(Parameters[0], VFParameter({0, VFParamKind::Vector}));
EXPECT_EQ(Parameters[1], VFParameter({1, VFParamKind::GlobalPredicate})); EXPECT_EQ(Parameters[1], VFParameter({1, VFParamKind::GlobalPredicate}));
EXPECT_EQ(ScalarName, "sin"); EXPECT_EQ(ScalarName, "sin");
} }
TEST_F(VFABIParserTest, ParseMaskingLLVM) {
EXPECT_TRUE(invokeParser("_ZGV_LLVM_M2v_sin(custom_vector_sin)"));
EXPECT_EQ(VF, (unsigned)2);
EXPECT_TRUE(IsMasked());
EXPECT_FALSE(IsScalable);
EXPECT_EQ(ISA, VFISAKind::LLVM);
EXPECT_EQ(Parameters.size(), (unsigned)2);
EXPECT_EQ(Parameters[0], VFParameter({0, VFParamKind::Vector}));
EXPECT_EQ(Parameters[1], VFParameter({1, VFParamKind::GlobalPredicate}));
EXPECT_EQ(ScalarName, "sin");
EXPECT_EQ(VectorName, "custom_vector_sin");
}
TEST_F(VFABIParserTest, ParseScalableMaskingLLVM) {
EXPECT_TRUE(invokeParser("_ZGV_LLVM_Mxv_sin(custom_vector_sin)"));
EXPECT_TRUE(IsMasked());
EXPECT_TRUE(IsScalable);
EXPECT_EQ(ISA, VFISAKind::LLVM);
EXPECT_EQ(Parameters.size(), (unsigned)2);
EXPECT_EQ(Parameters[0], VFParameter({0, VFParamKind::Vector}));
EXPECT_EQ(Parameters[1], VFParameter({1, VFParamKind::GlobalPredicate}));
EXPECT_EQ(ScalarName, "sin");
EXPECT_EQ(VectorName, "custom_vector_sin");
}
TEST_F(VFABIParserTest, ParseScalableMaskingLLVMSincos) {
EXPECT_TRUE(invokeParser("_ZGV_LLVM_Mxvl8l8_sincos(custom_vector_sincos)"));
EXPECT_TRUE(IsMasked());
EXPECT_TRUE(IsScalable);
EXPECT_EQ(ISA, VFISAKind::LLVM);
EXPECT_EQ(Parameters.size(), (unsigned)4);
EXPECT_EQ(Parameters[0], VFParameter({0, VFParamKind::Vector}));
EXPECT_EQ(Parameters[1], VFParameter({1, VFParamKind::OMP_Linear, 8}));
EXPECT_EQ(Parameters[2], VFParameter({2, VFParamKind::OMP_Linear, 8}));
EXPECT_EQ(Parameters[3], VFParameter({3, VFParamKind::GlobalPredicate}));
EXPECT_EQ(ScalarName, "sincos");
EXPECT_EQ(VectorName, "custom_vector_sincos");
}
class VFABIAttrTest : public testing::Test { class VFABIAttrTest : public testing::Test {
protected: protected:
void SetUp() override { void SetUp() override {
M = parseAssemblyString(IR, Err, Ctx); M = parseAssemblyString(IR, Err, Ctx);
// Get the only call instruction in the block, which is the first // Get the only call instruction in the block, which is the first
// instruction. // instruction.
CI = dyn_cast<CallInst>(&*(instructions(M->getFunction("f")).begin())); CI = dyn_cast<CallInst>(&*(instructions(M->getFunction("f")).begin()));
} }
Show All 31 Lines