Page MenuHomePhabricator

[GWP-ASan] 32-bit test pointers, allow multi-init for test.
ClosedPublic

Authored by hctim on Dec 6 2019, 7:59 AM.

Details

Summary

GWP-ASan test currently fail on 32-bit platforms, as some of the pointers are
larger than uintptr_t on 32-bit platforms. Fix up all those instances.

Also add an uncompress varint test where the result is an underflow.

Furthermore, allow multi-init for testing. Each gtest when running
check-gwp_asan apparently runs in its own instance, but when integrating
these tests into Android, this behaviour isn't the same. We remove the
global multi-init check here, to allow for testing to work elsewhere, and we're
not really worried about multi-init anyway as it's part of our contract with
the allocator.

Diff Detail

Event Timeline

hctim created this revision.Dec 6 2019, 7:59 AM
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptDec 6 2019, 7:59 AM
Herald added subscribers: llvm-commits, Restricted Project. · View Herald Transcript
eugenis accepted this revision.Dec 6 2019, 10:22 AM

LGTM

This revision is now accepted and ready to land.Dec 6 2019, 10:22 AM
This revision was automatically updated to reflect the committed changes.