This is an archive of the discontinued LLVM Phabricator instance.

[lldb][test] Handle .categories lookup for inline tests.
ClosedPublic

Authored by rupprecht on Dec 5 2019, 4:35 PM.

Details

Summary

When creating a test with lldbinline.MakeInlineTest(), the reported inspect.getfile(test.__class__) is lldbtest.pyc, meaning any .categories file will be ineffective for those tests. Check for the test_filename first, which inline tests will set.

Additionally, raise an error with the starting dir if .categories is not found. This makes the problem more obvious when it occurs: when the test is separated from the test framework tree.

Diff Detail

Event Timeline

rupprecht created this revision.Dec 5 2019, 4:35 PM
Herald added a project: Restricted Project. · View Herald TranscriptDec 5 2019, 4:35 PM

Build result: pass - 60539 tests passed, 0 failed and 726 were skipped.

Log files: console-log.txt, CMakeCache.txt

JDevlieghere accepted this revision.Dec 5 2019, 5:39 PM
This revision is now accepted and ready to land.Dec 5 2019, 5:39 PM
labath accepted this revision.Dec 6 2019, 12:25 AM
This revision was automatically updated to reflect the committed changes.