[llvm-readelf/llvm-readobj] - Remove getSecTypeName() helper.

[grimar]

Summary

We do not need it, we have
object::getELFSectionTypeName that can be used instead.

[jhenderson]

LGTM.

llvm/tools/llvm-readobj/ELFDumper.cpp

public:
   const Elf_GnuHash *getGnuHashTable() const { return GnuHashTable; }
 
   Expected<std::vector<VerDef>>
   getVersionDefinitions(const Elf_Shdr *Sec) const;
   Expected<std::vector<VerNeed>>
   getVersionDependencies(const Elf_Shdr *Sec) const;
 };
 
-static StringRef getSecTypeName(unsigned Type) {
-  if (Type == ELF::SHT_GNU_versym)
-    return "SHT_GNU_versym";
-  if (Type == ELF::SHT_GNU_verdef)
-    return "SHT_GNU_verdef";
-  if (Type == ELF::SHT_GNU_verneed)
-    return "SHT_GNU_verneed";
-  llvm_unreachable("unexpected section type");
-}
-
 template <class ELFT>
 static Expected<StringRef> getLinkAsStrtab(const ELFFile<ELFT> *Obj,
                                            const typename ELFT::Shdr *Sec,
                                            unsigned SecNdx) {
   Expected<const typename ELFT::Shdr *> StrTabSecOrErr =
       Obj->getSection(Sec->sh_link);
   if (!StrTabSecOrErr)
     return createError("invalid section linked to " +
-                       getSecTypeName(Sec->sh_type) + " section with index " +
-                       Twine(SecNdx) + ": " +
+                       object::getELFSectionTypeName(
+                           Obj->getHeader()->e_machine, Sec->sh_type) +
+                       " section with index " + Twine(SecNdx) + ": " +
                        toString(StrTabSecOrErr.takeError()));
 
   Expected<StringRef> StrTabOrErr = Obj->getStringTable(*StrTabSecOrErr);
   if (!StrTabOrErr)
     return createError("invalid string table linked to " +
-                       getSecTypeName(Sec->sh_type) + " section with index " +
-                       Twine(SecNdx) + ": " +
+                       object::getELFSectionTypeName(
+                           Obj->getHeader()->e_machine, Sec->sh_type) +
+                       " section with index " + Twine(SecNdx) + ": " +
                        toString(StrTabOrErr.takeError()));
   return *StrTabOrErr;
 }
 
 template <class ELFT>
 Expected<std::vector<VerDef>>
 ELFDumper<ELFT>::getVersionDefinitions(const Elf_Shdr *Sec) const {
   const ELFFile<ELFT> *Obj = ObjF->getELFFile();
void GNUStyle<ELFT>::printGNUVersionSectionProlog(
   Expected<const typename ELFT::Shdr *> SymTabOrErr =
       Obj->getSection(Sec->sh_link);
   if (SymTabOrErr)
     SymTabName =
         unwrapOrError(this->FileName, Obj->getSectionName(*SymTabOrErr));
   else
     this->reportUniqueWarning(
         createError("invalid section linked to " +
-                    getSecTypeName(Sec->sh_type) + " section with index " +
-                    Twine(SecNdx) + ": " + toString(SymTabOrErr.takeError())));
+                    object::getELFSectionTypeName(Obj->getHeader()->e_machine,
+                                                  Sec->sh_type) +
+                    " section with index " + Twine(SecNdx) + ": " +
+                    toString(SymTabOrErr.takeError())));
 
   OS << " Addr: " << format_hex_no_prefix(Sec->sh_addr, 16)
      << "  Offset: " << format_hex(Sec->sh_offset, 8)
      << "  Link: " << Sec->sh_link << " (" << SymTabName << ")\n";
 }
 
 template <class ELFT>
 void GNUStyle<ELFT>::printVersionSymbolSection(const ELFFile<ELFT> *Obj,