Page MenuHomePhabricator

[opencl] Fix address space deduction on array variables.
ClosedPublic

Authored by hliao on Dec 3 2019, 1:13 PM.

Details

Summary
  • The deduced address space needs applying to its element type as well.

Diff Detail

Event Timeline

hliao created this revision.Dec 3 2019, 1:13 PM
Herald added a project: Restricted Project. · View Herald TranscriptDec 3 2019, 1:13 PM
Anastasia accepted this revision.Dec 4 2019, 5:35 AM

LGTM! Thanks! Please address the comment in your final commit.

clang/lib/Sema/SemaDecl.cpp
6136

Maybe we should add a comment that we are adding an addr space on an array type first and then propagate to the element type.

This revision is now accepted and ready to land.Dec 4 2019, 5:35 AM
This revision was automatically updated to reflect the committed changes.