This is an archive of the discontinued LLVM Phabricator instance.

Differential D70957

[yaml2obj][test] - Remove excessive symtab-shinfo.yaml.
ClosedPublic

Authored by grimar on Dec 3 2019, 5:12 AM.

Details

Reviewers
jhenderson
MaskRay
• espindola
Commits
rG3b47e6efb9dd: [yaml2obj][test] - Remove excessive symtab-shinfo.yaml.
Summary

The same testing is performed in implicit-sections-info.yaml:
https://github.com/llvm-mirror/llvm/blob/master/test/tools/yaml2obj/implicit-sections-info.yaml

Diff Detail

Event Timeline

grimar created this revision.Dec 3 2019, 5:12 AM
Herald added a reviewer: • espindola. · View Herald TranscriptDec 3 2019, 5:12 AM
Herald added a project: Restricted Project. · View Herald Transcript
Herald added subscribers: arichardson, emaste. · View Herald Transcript
jhenderson accepted this revision.Dec 3 2019, 7:44 AM

LGTM.

This revision is now accepted and ready to land.Dec 3 2019, 7:44 AM
MaskRay accepted this revision.Dec 3 2019, 12:40 PM
Closed by commit rG3b47e6efb9dd: [yaml2obj][test] - Remove excessive symtab-shinfo.yaml. (authored by grimar). · Explain WhyDec 4 2019, 1:03 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
llvm/
test/
tools/
yaml2obj/
ELF/

Diff 232051

llvm/test/tools/yaml2obj/ELF/symtab-shinfo.yaml

  • This file was deleted.
## Check we are able to set sh_info field for SHT_SYMTAB sections.
# RUN: yaml2obj %s -o %t
# RUN: llvm-readobj --sections %t | FileCheck %s
# CHECK: Name: .symtab
# CHECK-NEXT: Type: SHT_SYMTAB
# CHECK-NEXT: Flags [
# CHECK-NEXT: ]
# CHECK-NEXT: Address:
# CHECK-NEXT: Offset:
# CHECK-NEXT: Size:
# CHECK-NEXT: Link:
# CHECK-NEXT: Info: 42
# CHECK: Name: .dynsym
# CHECK-NEXT: Type: SHT_DYNSYM
# CHECK-NEXT: Flags [
# CHECK-NEXT: SHF_ALLOC
# CHECK-NEXT: ]
# CHECK-NEXT: Address:
# CHECK-NEXT: Offset:
# CHECK-NEXT: Size:
# CHECK-NEXT: Link:
# CHECK-NEXT: Info: 26
--- !ELF
FileHeader:
Class: ELFCLASS64
Data: ELFDATA2LSB
Type: ET_REL
Machine: EM_X86_64
Sections:
- Name: .symtab
Info: 42
Type: SHT_SYMTAB
- Name: .dynsym
Info: 26
Type: SHT_DYNSYM
Symbols:
- Name: foo
Binding: STB_GLOBAL
DynamicSymbols:
- Name: bar
Binding: STB_GLOBAL