This is an archive of the discontinued LLVM Phabricator instance.

[lldb] Fix TestFormattersSBAPI test
ClosedPublic

Authored by aadsm on Dec 1 2019, 8:39 PM.

Details

Summary

This test was broken in two ways:

  • Using the wrong API (e.g.: format = instead of SetFormat)
  • The hex checker was only checking "01" which will pass with 0x0000001

Diff Detail

Event Timeline

aadsm created this revision.Dec 1 2019, 8:39 PM
Herald added a project: Restricted Project. · View Herald TranscriptDec 1 2019, 8:39 PM
clayborg accepted this revision.Dec 2 2019, 9:16 AM
clayborg added inline comments.
lldb/packages/Python/lldbsuite/test/python_api/formatters/TestFormattersSBAPI.py
71

both "format.format = lldb.eFormatOctal" and this are the same right?

This revision is now accepted and ready to land.Dec 2 2019, 9:16 AM
aadsm marked an inline comment as done.Dec 2 2019, 11:04 AM
aadsm added inline comments.
lldb/packages/Python/lldbsuite/test/python_api/formatters/TestFormattersSBAPI.py
71

Exactly.

This revision was automatically updated to reflect the committed changes.