Page MenuHomePhabricator

[clangd] Fix a regression issue in local rename.
ClosedPublic

Authored by hokein on Nov 29 2019, 6:03 AM.

Details

Summary

The regression is that we can't rename symbols in annonymous
namespaces.

Diff Detail

Event Timeline

hokein created this revision.Nov 29 2019, 6:03 AM
Herald added a project: Restricted Project. · View Herald TranscriptNov 29 2019, 6:03 AM
ilya-biryukov accepted this revision.Nov 29 2019, 6:35 AM

LGTM

clang-tools-extra/clangd/refactor/Rename.cpp
136

NIT: the comment seems to duplicate the code, maybe remove it?

This revision is now accepted and ready to land.Nov 29 2019, 6:35 AM
This revision was automatically updated to reflect the committed changes.
hokein marked an inline comment as done.