ThreadSafeSTLVector and ThreadSafeSTLMap are not useful for achieving any degree of thread safety in LLDB
and should be removed before they are used in more places. They are only used (unsurprisingly incorrectly) in
ValueObjectSynthetic::GetChildAtIndex, so this patch replaces their use there with a simple mutex with which
we guard the related data structures. This doesn't make ValueObjectSynthetic::GetChildAtIndex
any more thread-safe, but on the other hand it at least allows us to get rid of the ThreadSafeSTL* data structures
without changing the observable behaviour of ValueObjectSynthetic (beside that it is now a few bytes smaller).
Details
Details
Diff Detail
Diff Detail
Event Timeline
Comment Actions
I'm yet to see a non-trivial algorithm, which can be made thread-safe by employing "thread safe" containers. +1 for deleting these and sorting the ValueObjectSynthetic issues later.