This is an archive of the discontinued LLVM Phabricator instance.

LTOVisibility.rst: fix up syntax in example
ClosedPublic

Authored by dankamongmen on Nov 26 2019, 9:53 PM.

Details

Summary

Pretty self-evident. This example was missing an lparen. Added it, and fixed up the ASCII art.

Diff Detail

Event Timeline

dankamongmen created this revision.Nov 26 2019, 9:53 PM
pcc accepted this revision.Nov 27 2019, 8:52 AM

LGTM

This revision is now accepted and ready to land.Nov 27 2019, 8:52 AM

Thanks, @pcc! Is there anything I need to do, or am I just waiting on someone to merge this?

I hate to bother anyone, but can this go ahead and get merged? :) thanks

I hate to bother anyone, but can this go ahead and get merged? :) thanks

Typically the author commits the patch, unless they don't have commit access and request the reviewer to commit for them, but I don't see a request for that here.

Typically the author commits the patch, unless they don't have commit access and request the reviewer to commit for them, but I don't see a request for that here.

Thanks, Teresa. I indeed do not have commit access (so far as I know or can tell, anyway), so please consider this comment to be such a request.

Typically the author commits the patch, unless they don't have commit access and request the reviewer to commit for them, but I don't see a request for that here.

Thanks, Teresa. I indeed do not have commit access (so far as I know or can tell, anyway), so please consider this comment to be such a request.

I can go ahead and take care of committing for you today. BTW if you plan to contribute more and want commit access, the instructions are here: https://llvm.org/docs/DeveloperPolicy.html#new-contributors

This revision was automatically updated to reflect the committed changes.