This is an archive of the discontinued LLVM Phabricator instance.

Differential D70748

[clang test] Do not assume default target
ClosedPublic

Authored by thopre on Nov 26 2019, 3:10 PM.

Details

Reviewers
thegameg
Commits
rG717140a0dcc6: [clang test] Do not assume default target
Summary

clang test Driver/darwin-opt-record.c assumes the default target is
x86_64 by its uses of the -arch x86_64 and -arch x86_64h and thus fail
on systems where it is not the case. Adding a target
x86_64-apple-darwin10 reveals another problem: the driver refuses 2
-arch for an assembly output so this commit also changes the output to
be an object file.

Diff Detail

Event Timeline

thopre created this revision.Nov 26 2019, 3:10 PM
Herald added a project: Restricted Project. · View Herald TranscriptNov 26 2019, 3:10 PM
Herald added a subscriber: cfe-commits. · View Herald Transcript
Harbormaster completed remote builds in B41521: Diff 231141.Nov 26 2019, 3:13 PM
thegameg accepted this revision.Dec 2 2019, 8:40 AM

LGTM, thanks for fixing this.

This revision is now accepted and ready to land.Dec 2 2019, 8:40 AM
thopre closed this revision.Dec 2 2019, 2:58 PM

Committed as 717140a0dcc651ca2fec23248d1675fb2d388b9c

Revision Contents

PathSize
clang/
test/
Driver/
2 lines

Diff 231141

clang/test/Driver/darwin-opt-record.c

// REQUIRES: system-darwin // REQUIRES: system-darwin
// RUN: %clang -### -S -o FOO -fsave-optimization-record -arch x86_64 -arch x86_64h %s 2>&1 | FileCheck %s --check-prefix=CHECK-MULTIPLE-ARCH // RUN: %clang -target x86_64-apple-darwin10 -### -c -o FOO -fsave-optimization-record -arch x86_64 -arch x86_64h %s 2>&1 | FileCheck %s --check-prefix=CHECK-MULTIPLE-ARCH
// //
// CHECK-MULTIPLE-ARCH: "-cc1" // CHECK-MULTIPLE-ARCH: "-cc1"
// CHECK-MULTIPLE-ARCH: "-opt-record-file" "FOO-x86_64.opt.yaml" // CHECK-MULTIPLE-ARCH: "-opt-record-file" "FOO-x86_64.opt.yaml"
// CHECK-MULTIPLE-ARCH: "-cc1" // CHECK-MULTIPLE-ARCH: "-cc1"
// CHECK-MULTIPLE-ARCH: "-opt-record-file" "FOO-x86_64h.opt.yaml" // CHECK-MULTIPLE-ARCH: "-opt-record-file" "FOO-x86_64h.opt.yaml"